Source Zoom: Fix authenticator bug and add missing fields #35369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii added area/connectors 
Contributor
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
octavia-squidington-iii added the area/documentation 
…risto/zoom-fixes
ChristoGrab commented Feb 28, 2024
| parent_stream_configs: | ||
| - stream: "#/definitions/meetings_list_tmp_stream" | ||
| parent_key: "uuid" | ||
| parent_key: "id" |
Contributor Author
There was a problem hiding this comment.
The Zoom docs state that either a uuid or id can be provided. However, in my tests using the "uuid" in requests simply returned a "Meeting does not exist" message. By changing to "id" I was able to successfully fetch the records in our account.
ChristoGrab commented Feb 28, 2024
| parent_stream_configs: | ||
| - stream: "#/definitions/meetings_list_tmp_stream" | ||
| parent_key: "uuid" | ||
| parent_key: "id" |
Contributor Author
There was a problem hiding this comment.
Same as comment above
katmarkham approved these changes Mar 4, 2024
bazarnov suggested changes Mar 12, 2024
Contributor
bazarnov left a comment
bazarnov left a comment There was a problem hiding this comment.
Looks good! But, the changes should be applied. LGTM once fixed.
airbyte-integrations/connectors/source-zoom/integration_tests/expected_records.jsonl Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-zoom/source_zoom/schemas/meeting_poll_results.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-zoom/source_zoom/schemas/users.json Outdated Show resolved Hide resolved
bazarnov approved these changes Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
The Zoom connector has been down for some time, and due to lacking a sandbox account the updates to the authenticator introduced in 1.0.0 were never published. A test account has now been set up, and we are able to at least verify the ability to connect successfully to the API and sync data for multiple streams. All
webinarstreams remain untested at this time, and we do not currently plan to add integration tests for these streams as this is a Community connector.How
Bugs
Schemas
meeting_list_tmpandwebinar_list_tmpparent streams.meeting_idproperty inmeeting_registration_questionsstreamQA
🚨🚨 User Impact
Users will be able to create connections and sync data again. This is a breaking change due to the new authenticator introduced in 1.0.0 and a retyped schema property. Users with existing connections will need to migrate by setting up their server-to-server apps in Zoom for the new authenticator, and refresh schemas if syncing data from the "meeting_registration_questions" stream.