Skip to content

Conversation

@edgao
Copy link
Contributor

@edgao edgao commented Feb 15, 2024

incorporates changes from @gisripa 's #35342 as well as all the stacked CDK PRs.

from #35342 - move all of the schema change-detection code from sqlgenerator into destinationhandler. Also split out a BigqueryDestinationHandlerTest (unit test) class from the preexisting BigquerySqlGeneratorTest.

as noted in code comments - bigquery doesn't like frequent small updates on tables, so not implementing a true state table.

@vercel
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 7:14pm
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao marked this pull request as ready for review February 15, 2024 00:18
@edgao edgao requested a review from a team as a code owner February 15, 2024 00:18
@edgao edgao marked this pull request as draft February 15, 2024 15:28
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from 5c1421f to 76bc3be Compare February 15, 2024 15:29
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from 3829bea to bbe9cde Compare February 21, 2024 00:28
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch 2 times, most recently from dbf54d6 to 7ff3c33 Compare February 21, 2024 16:11
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 21, 2024
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from bbe9cde to 9f7d650 Compare February 21, 2024 16:11
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from 7ff3c33 to bcabf0c Compare February 21, 2024 20:34
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from 9f7d650 to 863ef4a Compare February 21, 2024 20:34
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Feb 21, 2024
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from bcabf0c to dd5100a Compare February 21, 2024 20:45
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Feb 21, 2024
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from 863ef4a to 74528dc Compare February 21, 2024 20:45
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from dd5100a to f095f49 Compare February 21, 2024 21:32
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from 74528dc to eaad0b5 Compare February 21, 2024 21:32
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from f095f49 to c352217 Compare February 21, 2024 21:42
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone branch from eaad0b5 to 9e0fabb Compare February 21, 2024 21:43
@edgao edgao force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from c352217 to c4b5368 Compare February 21, 2024 21:44
@octavia-squidington-iii octavia-squidington-iii removed the CDK Connector Development Kit label Feb 21, 2024
@gisripa gisripa force-pushed the edgao/staging_csv_timestamp_timezone_bigquery branch from ce77de0 to 64fb4cb Compare March 4, 2024 19:10
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 4, 2024
@gisripa gisripa merged commit 160ec72 into master Mar 4, 2024
@gisripa gisripa deleted the edgao/staging_csv_timestamp_timezone_bigquery branch March 4, 2024 19:43
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com> Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery

4 participants