- Notifications
You must be signed in to change notification settings - Fork 4.9k
Destination bigquery: upgrade cdk #35315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination bigquery: upgrade cdk #35315
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
5c1421f to 76bc3be Compare 3829bea to bbe9cde Compare dbf54d6 to 7ff3c33 Compare bbe9cde to 9f7d650 Compare 7ff3c33 to bcabf0c Compare 9f7d650 to 863ef4a Compare bcabf0c to dd5100a Compare 863ef4a to 74528dc Compare dd5100a to f095f49 Compare 74528dc to eaad0b5 Compare f095f49 to c352217 Compare eaad0b5 to 9e0fabb Compare c352217 to c4b5368 Compare Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
ce77de0 to 64fb4cb Compare Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com> Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>

incorporates changes from @gisripa 's #35342 as well as all the stacked CDK PRs.
from #35342 - move all of the schema change-detection code from sqlgenerator into destinationhandler. Also split out a BigqueryDestinationHandlerTest (unit test) class from the preexisting BigquerySqlGeneratorTest.
as noted in code comments - bigquery doesn't like frequent small updates on tables, so not implementing a true state table.