- Notifications
You must be signed in to change notification settings - Fork 4.9k
🐛 Source Orb: update enrich ledger entry with event stream to pass timeframe bounds #35005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Orb: update enrich ledger entry with event stream to pass timeframe bounds #35005
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
girarda left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change seems fine and pretty straightforward.
Tagging @marcosmarxm since you're more familiar than I am with how we review and test community connectors. Would you mind taking a look?
| 👋 Hi @marcosmarxm, just wanted to bump this PR in your inbox, we'd love to get this reviewed and merged to unblock a downstream API change we're scheduled to make, and want to make sure that the Airbyte connector works as expected after the change! |
| Hi @marcosmarxm, would you be able to take a look at this PR or is there somebody else we should reach out to? We'd like to get this shipped so that we can move forward with the downstream changes to our API. We were hoping to finish up the API changes before the start of this month, but now we'd just like to finish them up ASAP. Please let us know what we can do to help the process move faster |
| Working to get this merged asap @arshk123 |
| Sorry the delay folks its merged by #35897 |
What
Orb's event search API is moving to require a timestamp boundary alongside the
event_idto improve the performance of the endpoint. This PR updates the Airbyte connector to pass in the timestamp bounds derived from theledger_entry.created_atfield.How
We now use the
created_attimestamp in theledger_entryto determine the start and end bounds for the event search query.Recommended reading order
source.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
No breaking changes
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> testAfter merging: