Skip to content

Conversation

@ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Feb 8, 2024

What

Source Klaviyo is failing CAT tests due to missing fields in the stream schemas. The abnormal_state Incremental test also fails due to an API error being thrown when the time passed as a filtering request param is not in the past. Resolves #34996

How

  • Added missing fields to stream schemas
  • Small tweak to the logic for setting the timestamp filter in request_params for Incremental streams. If an abnormally large state value is passed as a filter, the API throws an error (logs in the linked issue). To avoid this, we already have logic to set the filter date to the current time if the value of state is in the future (ie, during our abnormal_state tests). However, it seems the API will still throw the error in this case, and needs the value to be set at least a few seconds in the past to make a successful request.
  • Updated expected records

Reading Order

  1. streams.py
  2. schemas/*.json

User Impact

Not a breaking change, no fields removed or retyped.

@vercel
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 8, 2024 4:12pm
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@ChristoGrab ChristoGrab marked this pull request as ready for review February 8, 2024 17:06
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 8, 2024 17:08
Copy link
Contributor

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChristoGrab ChristoGrab merged commit 72ee783 into master Feb 8, 2024
@ChristoGrab ChristoGrab deleted the christo/klaviyo-schemas branch February 8, 2024 18:02
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 21, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/klaviyo

4 participants