Partial CDK revert of #34186 #34461
Merged
Partial CDK revert of #34186 #34461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao approved these changes Jan 23, 2024
gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 3e317bd to 4576631 Compare 
octavia-squidington-iii added area/connectors gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 4576631 to 0f51dba Compare gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 0f51dba to bc0697b Compare This was referenced Jan 24, 2024
Merged
Contributor Author
| /publish-java-cdk
|
edgao approved these changes Jan 24, 2024
Contributor
edgao left a comment
edgao left a comment There was a problem hiding this comment.
one nit on javadoc comments, otherwise lgtm
Contributor
There was a problem hiding this comment.
nit: is this the stream's namespace, or the database schema? E.g. for a stream with namespace=public users - are we using public users (the original stream namespace), public_users (the final table schema name, after name-mangling), or airbyte_internal (the raw table schema name)?
gisripa force-pushed the gireesh/01-23-gireesh/cdk/resurrect-breaking branch from 6e46415 to 1171ebc Compare jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
## What * Resurrect removed signatures to fix compilation errors in Snowflake connector. * Partial revert of airbytehq#34186
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
## What * Resurrect removed signatures to fix compilation errors in Snowflake connector. * Partial revert of airbytehq#34186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What