Skip to content

Conversation

@darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Nov 8, 2023

What

Certification:

  • custom reports for report-based connector
  • backoff time <10min
  • actionable error messages

How

  • Added custom reports generation (UI screenshots added below)
  • decreased max_tries for backoff
  • updated error message for invalid dev token case
    image

image

image

image

@darynaishchenko darynaishchenko self-assigned this Nov 8, 2023
@vercel
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2023 5:26pm
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads labels Nov 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 9, 2023 18:13
@lazebnyi lazebnyi removed the request for review from a team November 10, 2023 09:18
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 10, 2023 09:27
@artem1205 artem1205 marked this pull request as draft November 13, 2023 14:40
@darynaishchenko darynaishchenko marked this pull request as ready for review November 14, 2023 16:13
@darynaishchenko darynaishchenko merged commit dc48c4f into master Nov 14, 2023
@darynaishchenko darynaishchenko deleted the daryna/source-bing-ads/custom-reports branch November 14, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads team/connectors-python

5 participants