Skip to content

🧹 remove source-file-secure #31477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2023
Merged

🧹 remove source-file-secure #31477

merged 1 commit into from
Oct 16, 2023

Conversation

@pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Oct 16, 2023 •
edited
Loading

What

As of #30984, source-file-secure has been integrated into source-file, and this is no longer needed.

Bye!

How

Delete code

🚨 User Impact 🚨

Users should not see any impact with this change since everyone has been moved over to source-file.
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 16, 2023 8:44pm
@pedroslopez Graphite App
Copy link
Contributor Author

pedroslopez commented Oct 16, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited by pedroslopez
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@pedroslopez pedroslopez changed the title remove source-file-secure 🧹 remove source-file-secure Oct 16, 2023
@pedroslopez pedroslopez marked this pull request as ready for review October 16, 2023 20:39
@pedroslopez pedroslopez requested a review from a team October 16, 2023 20:39
@pedroslopez pedroslopez force-pushed the pedro/remove_source-file-secure branch from 18600ed to d8ac293 Compare October 16, 2023 20:43
pedroslopez
pedroslopez commented Oct 16, 2023
View reviewed changes
airbyte-integrations/connectors/source-file/README.md
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
1. Make sure your changes are passing unit and integration tests
2. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use SemVer).
3. In addition to bumping the connector version of `source-file`, you must also increment the version of `source-file-secure` which depends on this source. The versions of these connectors should always remain in sync. Depending on the changes to `source-file`, you may also need to make changes to `source-file-secure` to retain compatibility.
Copy link
Contributor Author

@pedroslopez pedroslopez Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to remove this line
evantahler
evantahler approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-16 at 1 55 57 PM NICE.
@pedroslopez
Copy link
Contributor Author

pedroslopez commented Oct 16, 2023

/approve-and-merge reason="format never ran and this is just deleting code"
@octavia-approvington
Copy link
Contributor

octavia-approvington commented Oct 16, 2023

It's time
fine lets go
@octavia-approvington octavia-approvington merged commit c6ce495 into master Oct 16, 2023
@octavia-approvington octavia-approvington deleted the pedro/remove_source-file-secure branch October 16, 2023 22:52
@pedroslopez pedroslopez mentioned this pull request Oct 17, 2023
Closed
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
@pedroslopez @ariesgun
🧹 remove source-file-secure (airbytehq#31477)
7dca204
@aleloi aleloi mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues connectors/source/file connectors/source/file-secure

5 participants

@pedroslopez @octavia-approvington @evantahler @octavia-squidington-iii