Skip to content

🐛 Source Facebook Marketing: do not request funding_source_details if api raises an error #31284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2023
Merged

🐛 Source Facebook Marketing: do not request funding_source_details if api raises an error #31284

merged 3 commits into from
Oct 11, 2023

Conversation

@davydov-d
Copy link
Contributor

@davydov-d davydov-d commented Oct 11, 2023

What

FB API raises an error in rare and random cases when the connector tries to access the funding_source_details field of the AdAccount stream.
https://github.com/airbytehq/oncall/issues/3031

How

Retry the request without this field if the API raises an error

🚨 User Impact 🚨

Not a breaking change
@vercel
Copy link

vercel bot commented Oct 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2023 3:25pm
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited by davydov-d
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@davydov-d davydov-d marked this pull request as ready for review October 11, 2023 14:55
@airbyte-oss-build-runner
Copy link
Collaborator

airbyte-oss-build-runner commented Oct 11, 2023

source-facebook-marketing test report (commit 2fe2d424d4) - ✅

⏲️ Total pipeline duration: 83mn16s

Step Result
Build source-facebook-marketing docker image for platform(s) linux/x86_64 ✅
Unit tests ✅
Integration tests ✅
Acceptance tests ✅
Code format checks ✅
Validate metadata for source-facebook-marketing ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-facebook-marketing test
@davydov-d davydov-d merged commit 61aa119 into master Oct 11, 2023
@davydov-d davydov-d deleted the ddavydov/oncall-3031-source-fb-marketing-unsupported-request branch October 11, 2023 16:52
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
@davydov-d @ariesgun
🐛 Source Facebook Marketing: do not request funding_source_details if…
bd6cb5e 
… api raises an error (airbytehq#31284) Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing

5 participants

@davydov-d @airbyte-oss-build-runner @bazarnov @octavia-squidington-iii