🚨 🚨 Source Google Ads: update schemas and names of default streams #31048

tolik0 · 2023-10-04T12:01:23Z

What

This PR focuses on updating the schemas and default stream names in alignment with Google Ads documentation.
Fixes:

Closes Bigquery Paritions should only be on the first PK (actually a source issue) #30988
Closes Source Google Ads: Align stream names with Google Ads API resource naming #30562
Closes https://github.com/airbytehq/oncall/issues/3103 (source-google-ads)
Closes https://github.com/airbytehq/oncall/issues/3036 (source-google-ads)
Closes https://github.com/airbytehq/oncall/issues/3109 (source-google-ads)

How

Stream names have been updated to correspond with Google Ads resource names.
Field types have been modified as per Google Ads documentation.

🚨 User Impact 🚨

This release includes enhancements to the default schemas and updates to stream names. Users should refresh the source schema and reset affected streams after upgrading to ensure uninterrupted syncs.

vercel · 2023-10-04T12:01:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 16, 2023 0:08am

github-actions · 2023-10-04T12:01:45Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-04T12:13:26Z

source-google-ads test report (commit `75626b0c36`) - ❌

⏲️ Total pipeline duration: 07mn23s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-04T12:38:56Z

source-google-ads test report (commit `e34beb68b0`) - ❌

⏲️ Total pipeline duration: 06mn58s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-04T14:44:00Z

source-google-ads test report (commit `75626b0c36`) - ❌

⏲️ Total pipeline duration: 07mn28s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-04T14:48:36Z

source-google-ads test report (commit `4d8844ba38`) - ❌

⏲️ Total pipeline duration: 58.00s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-google-ads	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-04T15:09:52Z

source-google-ads test report (commit `97819f1bbe`) - ❌

⏲️ Total pipeline duration: 01mn06s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform linux/x86_64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-google-ads	❌
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

davydov-d

Please make all checks green and wait for Catherine's review

airbyte-oss-build-runner · 2023-10-04T22:32:17Z

source-google-ads test report (commit `44869b743b`) - ❌

⏲️ Total pipeline duration: 07mn16s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	❌
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-04T22:45:29Z

source-google-ads test report (commit `53c656a117`) - ✅

⏲️ Total pipeline duration: 07mn45s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-05T05:53:09Z

source-google-ads test report (commit `c3457e8c7b`) - ✅

⏲️ Total pipeline duration: 06mn12s

Step	Result
Connector package install	✅
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

bnchrch

Just some changes for the breaking change message but other than that it lgtm! 💎

airbyte-integrations/connectors/source-google-ads/metadata.yaml

docs/integrations/sources/google-ads-migrations.md

evantahler · 2023-10-13T17:27:20Z

Any progress on this one?

airbyte-oss-build-runner · 2023-10-14T04:52:07Z

source-google-ads test report (commit `f37d26d2eb`) - ❌

⏲️ Total pipeline duration: 07mn16s

Step	Result
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-14T09:05:21Z

source-google-ads test report (commit `e0effa2296`) - ✅

⏲️ Total pipeline duration: 08mn45s

Step	Result
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-14T09:37:31Z

source-google-ads test report (commit `11abf82922`) - ✅

⏲️ Total pipeline duration: 04mn48s

Step	Result
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group.json

airbyte-oss-build-runner · 2023-10-16T12:06:42Z

source-google-ads test report (commit `727c04c782`) - ✅

⏲️ Total pipeline duration: 10mn38s

Step	Result
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

airbyte-oss-build-runner · 2023-10-16T12:21:24Z

source-google-ads test report (commit `7a16daf601`) - ✅

⏲️ Total pipeline duration: 10mn46s

Step	Result
Build source-google-ads docker image for platform(s) linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate metadata for source-google-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test

…irbytehq#31048) Co-authored-by: tolik0 <tolik0@users.noreply.github.com> Co-authored-by: Ben Church <ben@airbyte.io>

octavia-squidington-iii added area/connectors Connector related issues connectors/source/google-ads labels Oct 4, 2023

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 4, 2023

tolik0 marked this pull request as ready for review October 4, 2023 12:03

vercel bot deployed to Preview October 4, 2023 12:04 View deployment

tolik0 added the team/connectors-python label Oct 4, 2023

tolik0 force-pushed the tolik0/source-google-ads/fix-default-schemas branch from e34beb6 to 75626b0 Compare October 4, 2023 14:34

tolik0 requested review from clnoll and davydov-d October 4, 2023 14:46

davydov-d added the breaking-change Don't merge me unless you are ready. label Oct 4, 2023

davydov-d changed the title ~~Source Google Ads: update schemas and names of default streams~~ 🚨 🚨 Source Google Ads: update schemas and names of default streams Oct 4, 2023

davydov-d approved these changes Oct 4, 2023

View reviewed changes

tolik0 force-pushed the tolik0/source-google-ads/fix-default-schemas branch from 97819f1 to 44869b7 Compare October 4, 2023 22:23

vercel bot deployed to Preview October 5, 2023 05:47 View deployment

davydov-d requested a review from bnchrch October 6, 2023 05:08

tolik0 mentioned this pull request Oct 6, 2023

source-google-ads: Fix type of google_ads_campaign_budget.status #30997

Closed

bnchrch approved these changes Oct 6, 2023

View reviewed changes

airbyte-integrations/connectors/source-google-ads/metadata.yaml Outdated Show resolved Hide resolved

docs/integrations/sources/google-ads-migrations.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 13, 2023 17:35 View deployment

tolik0 requested a review from a team as a code owner October 13, 2023 22:33

Update expected records

e0effa2

tolik0 requested a review from bazarnov October 14, 2023 09:03

vercel bot deployed to Preview October 14, 2023 09:32 View deployment

bazarnov suggested changes Oct 14, 2023

View reviewed changes

airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group.json Outdated Show resolved Hide resolved

tolik0 added 2 commits October 16, 2023 14:50

Delete all enum from schemas

04620b2

Update docs

727c04c

tolik0 force-pushed the tolik0/source-google-ads/fix-default-schemas branch from 11abf82 to 727c04c Compare October 16, 2023 11:53

vercel bot deployed to Preview October 16, 2023 11:55 View deployment

bazarnov approved these changes Oct 16, 2023

View reviewed changes

Automated Commit - Formatting Changes

7a16daf

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 16, 2023

tolik0 merged commit cb3df14 into master Oct 16, 2023

tolik0 deleted the tolik0/source-google-ads/fix-default-schemas branch October 16, 2023 12:23

girarda mentioned this pull request Feb 2, 2024

[DO NOT MERGE] source-google-ads: rename streams to 1.0.0's schema #34813

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🚨 🚨 Source Google Ads: update schemas and names of default streams #31048

🚨 🚨 Source Google Ads: update schemas and names of default streams #31048

Uh oh!

tolik0 commented Oct 4, 2023 •

edited by evantahler

Loading

vercel bot commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited by tolik0

Loading

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 4, 2023

davydov-d left a comment

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 4, 2023

airbyte-oss-build-runner commented Oct 5, 2023

bnchrch left a comment

Uh oh!

Uh oh!

evantahler commented Oct 13, 2023

airbyte-oss-build-runner commented Oct 14, 2023

airbyte-oss-build-runner commented Oct 14, 2023

airbyte-oss-build-runner commented Oct 14, 2023

Uh oh!

airbyte-oss-build-runner commented Oct 16, 2023

airbyte-oss-build-runner commented Oct 16, 2023

Labels

8 participants

🚨 🚨 Source Google Ads: update schemas and names of default streams #31048

🚨 🚨 Source Google Ads: update schemas and names of default streams #31048

Uh oh!

Conversation

tolik0 commented Oct 4, 2023 • edited by evantahler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

🚨 User Impact 🚨

vercel bot commented Oct 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

github-actions bot commented Oct 4, 2023 • edited by tolik0 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 75626b0c36) - ❌

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit e34beb68b0) - ❌

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 75626b0c36) - ❌

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 4d8844ba38) - ❌

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 97819f1bbe) - ❌

davydov-d left a comment

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 44869b743b) - ❌

airbyte-oss-build-runner commented Oct 4, 2023

source-google-ads test report (commit 53c656a117) - ✅

airbyte-oss-build-runner commented Oct 5, 2023

source-google-ads test report (commit c3457e8c7b) - ✅

bnchrch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evantahler commented Oct 13, 2023

airbyte-oss-build-runner commented Oct 14, 2023

source-google-ads test report (commit f37d26d2eb) - ❌

airbyte-oss-build-runner commented Oct 14, 2023

source-google-ads test report (commit e0effa2296) - ✅

airbyte-oss-build-runner commented Oct 14, 2023

source-google-ads test report (commit 11abf82922) - ✅

Uh oh!

airbyte-oss-build-runner commented Oct 16, 2023

source-google-ads test report (commit 727c04c782) - ✅

airbyte-oss-build-runner commented Oct 16, 2023

source-google-ads test report (commit 7a16daf601) - ✅

Labels

8 participants

tolik0 commented Oct 4, 2023 •

edited by evantahler

Loading

vercel bot commented Oct 4, 2023 •

edited

Loading

github-actions bot commented Oct 4, 2023 •

edited by tolik0

Loading

source-google-ads test report (commit `75626b0c36`) - ❌

source-google-ads test report (commit `e34beb68b0`) - ❌

source-google-ads test report (commit `75626b0c36`) - ❌

source-google-ads test report (commit `4d8844ba38`) - ❌

source-google-ads test report (commit `97819f1bbe`) - ❌

source-google-ads test report (commit `44869b743b`) - ❌

source-google-ads test report (commit `53c656a117`) - ✅

source-google-ads test report (commit `c3457e8c7b`) - ✅

source-google-ads test report (commit `f37d26d2eb`) - ❌

source-google-ads test report (commit `e0effa2296`) - ✅

source-google-ads test report (commit `11abf82922`) - ✅

source-google-ads test report (commit `727c04c782`) - ✅

source-google-ads test report (commit `7a16daf601`) - ✅