CAT: add option to test with specific deployment_mode #30838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor Author
| Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
pedroslopez force-pushed the pedro/cat-deployment-mode branch from 6f9c471 to 408d4d1 Compare 
octavia-squidington-iii added area/connectors pedroslopez force-pushed the pedro/cat-deployment-mode branch 2 times, most recently from d43cae3 to 6d6de39 Compare 
pedroslopez force-pushed the pedro/cat-deployment-mode branch from 6d6de39 to 1450bf3 Compare pedroslopez changed the title 
evantahler approved these changes Oct 2, 2023
Comment on lines +150 to +151
| if self._deployment_mode: | ||
| container = container.with_env_variable("DEPLOYMENT_MODE", self._deployment_mode.upper()) |
Contributor
There was a problem hiding this comment.
Meaning that if there is no _deployment_mode, the ENV isn't set 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
In order to safely remove strict encrypt (e.g. source-file-secure), we need a way to test CAT with specific deployment modes.
This adds a new
deployment_modeconfig option in tests that will pass along the deployment mode to the connector.See usage example in https://github.com/airbytehq/airbyte/pull/30984/files#diff-2edc22a669c20da40e3afc0261807b4cec538388f39f703d1b64fd1478724024R9-R21
close #30627
How
deployment_modeconfig option