Source Notion: Avoid KeyError when no next_cursor exists #30641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ChristoGrab changed the title next_cursor exists 
octavia-squidington-iii added area/connectors 
Contributor
|
| Step | Result |
|---|---|
| Connector package install | ✅ |
| Build source-notion docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ❌ |
| Code format checks | ✅ |
| Validate airbyte-integrations/connectors/source-notion/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ✅ |
| QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-notion test Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
This PR should resolve
oncall #2712
How
Small change to handle no
next_cursorexisting in response json.Notes
This PR will fail acceptance tests until schema changes have been merged. I'm adding it now just to be ready.