Skip to content

Conversation

@artem1205
Copy link
Contributor

@artem1205 artem1205 commented Sep 4, 2023

What

Resolve #16910

How

add streams:

  • Article Votes
  • Article Comments
  • Article Comment Votes

make Post comment streams incremental

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 changed the title Source Zendesk Support: add streams: Article Votes, Article Comments, Article Comment Votes ✨Source Zendesk Support: add streams: Article Votes, Article Comments, Article Comment Votes Sep 4, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 4, 2023
@artem1205 artem1205 marked this pull request as ready for review September 4, 2023 14:59
@artem1205 artem1205 self-assigned this Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

source-zendesk-support test report (commit 3e0a757311) - ❌

⏲️ Total pipeline duration: 11mn35s

Step Result
Connector package install
Build source-zendesk-support docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

source-zendesk-support test report (commit 3e0a757311) - ❌

⏲️ Total pipeline duration: 11mn02s

Step Result
Connector package install
Build source-zendesk-support docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

source-zendesk-support test report (commit bc2b39f623) - ✅

⏲️ Total pipeline duration: 03mn00s

Step Result
Connector package install
Build source-zendesk-support docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test
@artem1205 artem1205 merged commit 0cfbfd2 into master Sep 5, 2023
@artem1205 artem1205 deleted the artem1205/source-zendesk-support-add-article-votes branch September 5, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support

4 participants