Skip to content

Conversation

@arsenlosenko
Copy link
Contributor

What

During certification it was noticed that two streams don't have any primary keys: ContactLists and PropertyHistory. This PR adds corresponding primary keys to these streams.

How

Specify vid primary key for stream PropertyHistory, and listID for ContactLists

@arsenlosenko arsenlosenko self-assigned this Aug 10, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot labels Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko arsenlosenko marked this pull request as ready for review August 10, 2023 11:42
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit cfc3c2c1bc) - ❌

⏲️ Total pipeline duration: 11mn43s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit cfc3c2c1bc) - ❌

⏲️ Total pipeline duration: 11mn03s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit bc3a516732) - ✅

⏲️ Total pipeline duration: 11mn55s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test
@octavia-squidington-iii
Copy link
Collaborator

source-hubspot test report (commit 7794781177) - ✅

⏲️ Total pipeline duration: 11mn19s

Step Result
Validate airbyte-integrations/connectors/source-hubspot/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-hubspot docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-hubspot test
@arsenlosenko arsenlosenko merged commit 0437c1d into master Aug 11, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-hubspot-add-primary-keys branch August 11, 2023 11:26
cloud:
enabled: true
dockerImageTag: 1.3.1
dockerImageTag: 1.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arsenlosenko unless you want to pin hubspot to a previous version we don't need this tag, it will keep cloud up to date with oss

harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
… streams (airbytehq#29326) * Source Hubspot: specify primary keys for ContactLists and PropertyHistory streams * Update changelog * Update expected records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/hubspot

5 participants