Source S3: always show S3 Access Key fields #28639

ChristoGrab · 2023-07-24T21:09:16Z

What

Changed S3 Access Key fields to always be visible since they are so commonly needed during setup.

How

Set always-show to True for both Access Key fields
Removed comment about them being in Optional Fields from documentation

github-actions · 2023-07-24T21:09:44Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-07-24T21:33:25Z

source-s3 test report (commit `316366143d`) - ❌

⏲️ Total pipeline duration: 02mn14s

Step	Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

octavia-squidington-iii · 2023-07-25T04:54:37Z

source-s3 test report (commit `f687395d57`) - ❌

⏲️ Total pipeline duration: 01mn38s

Step	Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

octavia-squidington-iii · 2023-07-25T05:24:26Z

source-s3 test report (commit `2ed6b601fb`) - ❌

⏲️ Total pipeline duration: 24mn27s

Step	Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

octavia-squidington-iii · 2023-07-25T08:12:21Z

source-s3 test report (commit `09033ece20`) - ❌

⏲️ Total pipeline duration: 24mn23s

Step	Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	✅
Unit tests	✅
Integration tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

octavia-squidington-iii · 2023-07-31T03:30:52Z

source-s3 test report (commit `09581078fb`) - ❌

⏲️ Total pipeline duration: 03mn51s

Step	Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	✅
Code format checks	✅
Connector package install	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

sherifnada · 2023-09-07T23:40:29Z

@ChristoGrab the build should be green now, feel free to proceed with merging this

github-actions · 2023-09-07T23:44:54Z

source-s3 test report (commit `ddddb80119`) - ❌

⏲️ Total pipeline duration: 01mn53s

Step	Result
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

github-actions · 2023-09-07T23:49:16Z

source-s3 test report (commit `ddddb80119`) - ❌

⏲️ Total pipeline duration: 02mn01s

Step	Result
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

github-actions · 2023-09-08T19:08:07Z

source-s3 test report (commit `d82a25f1ed`) - ❌

⏲️ Total pipeline duration: 01mn40s

Step	Result
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	❌
Code format checks	✅
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	❌

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

github-actions · 2023-09-08T19:20:53Z

source-s3 test report (commit `77a5c22dcd`) - ✅

⏲️ Total pipeline duration: 10mn11s

Step	Result
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

ChristoGrab · 2023-09-11T14:29:15Z

Yup, we're green now! I think I still need approval, then should be good to merge

github-actions · 2023-09-11T18:01:34Z

source-s3 test report (commit `e649d48c0a`) - ✅

⏲️ Total pipeline duration: 10mn26s

Step	Result
Connector package install	✅
Build source-s3 docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅
Code format checks	✅
Validate airbyte-integrations/connectors/source-s3/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

ChristoGrab added 2 commits July 24, 2023 16:22

add always-true flag to s3 key fields

6b013d2

update s3 version

ee455ae

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3 labels Jul 24, 2023

Merge branch 'master' into source-s3-show-key-fields

85ebdc0

ChristoGrab changed the title ~~Source S3: always show S3 key fields~~ Source S3: always show S3 Access Key fields Jul 24, 2023

Update s3.md

3163661

ChristoGrab marked this pull request as ready for review July 24, 2023 21:29

ChristoGrab requested a review from sherifnada July 24, 2023 21:29

fix requirements.txt

f687395

save

2ed6b60

spec

09033ec

Merge branch 'master' into source-s3-show-key-fields

0958107

sherifnada added 2 commits September 7, 2023 16:39

Merge branch 'master' into source-s3-show-key-fields

2628229

Update metadata.yaml

ddddb80

ChristoGrab added 2 commits September 8, 2023 15:03

Merge branch 'master' into source-s3-show-key-fields

d82a25f

Update Dockerfile

77a5c22

sherifnada approved these changes Sep 11, 2023

View reviewed changes

Fix changelog

e649d48

ChristoGrab merged commit 5f990f4 into master Sep 11, 2023

ChristoGrab deleted the source-s3-show-key-fields branch September 11, 2023 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source S3: always show S3 Access Key fields #28639

Source S3: always show S3 Access Key fields #28639

Uh oh!

ChristoGrab commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited by ChristoGrab

Loading

octavia-squidington-iii commented Jul 24, 2023

octavia-squidington-iii commented Jul 25, 2023

octavia-squidington-iii commented Jul 25, 2023

octavia-squidington-iii commented Jul 25, 2023

octavia-squidington-iii commented Jul 31, 2023

sherifnada commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

github-actions bot commented Sep 8, 2023

github-actions bot commented Sep 8, 2023

ChristoGrab commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

Labels

4 participants

Source S3: always show S3 Access Key fields #28639

Source S3: always show S3 Access Key fields #28639

Uh oh!

Conversation

ChristoGrab commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

github-actions bot commented Jul 24, 2023 • edited by ChristoGrab Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

octavia-squidington-iii commented Jul 24, 2023

source-s3 test report (commit 316366143d) - ❌

octavia-squidington-iii commented Jul 25, 2023

source-s3 test report (commit f687395d57) - ❌

octavia-squidington-iii commented Jul 25, 2023

source-s3 test report (commit 2ed6b601fb) - ❌

octavia-squidington-iii commented Jul 25, 2023

source-s3 test report (commit 09033ece20) - ❌

octavia-squidington-iii commented Jul 31, 2023

source-s3 test report (commit 09581078fb) - ❌

sherifnada commented Sep 7, 2023

github-actions bot commented Sep 7, 2023

source-s3 test report (commit ddddb80119) - ❌

github-actions bot commented Sep 7, 2023

source-s3 test report (commit ddddb80119) - ❌

github-actions bot commented Sep 8, 2023

source-s3 test report (commit d82a25f1ed) - ❌

github-actions bot commented Sep 8, 2023

source-s3 test report (commit 77a5c22dcd) - ✅

ChristoGrab commented Sep 11, 2023

github-actions bot commented Sep 11, 2023

source-s3 test report (commit e649d48c0a) - ✅

Labels

4 participants

ChristoGrab commented Jul 24, 2023 •

edited

Loading

github-actions bot commented Jul 24, 2023 •

edited by ChristoGrab

Loading

source-s3 test report (commit `316366143d`) - ❌

source-s3 test report (commit `f687395d57`) - ❌

source-s3 test report (commit `2ed6b601fb`) - ❌

source-s3 test report (commit `09033ece20`) - ❌

source-s3 test report (commit `09581078fb`) - ❌

source-s3 test report (commit `ddddb80119`) - ❌

source-s3 test report (commit `ddddb80119`) - ❌

source-s3 test report (commit `d82a25f1ed`) - ❌

source-s3 test report (commit `77a5c22dcd`) - ✅

source-s3 test report (commit `e649d48c0a`) - ✅