Skip to content

Conversation

@btkcodedev
Copy link
Collaborator

What

Closes #27385
Updated start_date validation

How

Updated the pattern

Recommended reading order

  1. spec.json

🚨 User Impact 🚨

No breaking changes

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/mailgun labels Jul 19, 2023
@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@btkcodedev btkcodedev changed the title Source MailGun: Update start_date validation 🐛Source MailGun: Update start_date validation Jul 19, 2023
@marcosmarxm marcosmarxm added the team/tse Technical Support Engineers label Jul 19, 2023
@btkcodedev
Copy link
Collaborator Author

@marcosmarxm @archangelic Could you prioritize this? Cause, I'm working to migrate it to low code right now
Its just two line change :)

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Aug 5, 2023

Cause' its raising backward compatibility issues

@marcosmarxm
Copy link
Contributor

Closing this in favor of #29122 which is migrating the connector to low-code.

@marcosmarxm marcosmarxm closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/mailgun team/tse Technical Support Engineers

4 participants