🐛 Source Zendesk Support: Add handle 404 error #28397

lazebnyi · 2023-07-18T14:45:49Z

What

Certain Zendesk Support endpoints return a 404 error for some users, without providing any detailed information.

https://github.com/airbytehq/oncall/issues/2379

How

Add handle 404 error to should retry logic

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

github-actions · 2023-07-18T14:46:10Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

…rror

octavia-squidington-iii · 2023-07-18T14:58:07Z

source-zendesk-support test report (commit `e426f99e8c`) - ❌

⏲️ Total pipeline duration: 06mn22s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…rror

octavia-squidington-iii · 2023-07-18T17:24:03Z

source-zendesk-support test report (commit `8b013d76af`) - ❌

⏲️ Total pipeline duration: 07mn25s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…rror

octavia-squidington-iii · 2023-07-19T12:39:25Z

source-zendesk-support test report (commit `6e8b53c983`) - ❌

⏲️ Total pipeline duration: 18mn31s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…rror

octavia-squidington-iii · 2023-07-21T11:41:46Z

source-zendesk-support test report (commit `0a689a428e`) - ❌

⏲️ Total pipeline duration: 18mn26s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…rror

octavia-squidington-iii · 2023-07-24T10:10:01Z

source-zendesk-support test report (commit `529a284fa0`) - ✅

⏲️ Total pipeline duration: 14mn47s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

…rror

octavia-squidington-iii · 2023-07-25T16:11:06Z

source-zendesk-support test report (commit `56ae412ca0`) - ✅

⏲️ Total pipeline duration: 15mn53s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

octavia-squidington-iii · 2023-07-25T16:27:05Z

source-zendesk-support test report (commit `9f54510657`) - ✅

⏲️ Total pipeline duration: 14mn09s

Step	Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Code format checks	✅
Connector package install	✅
Build source-zendesk-support docker image for platform linux/x86_64	✅
Unit tests	✅
Acceptance tests	✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

Add handle 404 error

73f8eaa

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jul 18, 2023

octavia-squidington-iii added the connectors/source/zendesk-support label Jul 18, 2023

lazebnyi and others added 2 commits July 18, 2023 16:48

Updated PR number

2909287

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

e426f99

…rror

lazebnyi requested review from artem1205 and darynaishchenko July 18, 2023 17:14

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

8b013d7

…rror

darynaishchenko approved these changes Jul 19, 2023

View reviewed changes

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

6e8b53c

…rror

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

0a689a4

…rror

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

529a284

…rror

lazebnyi and others added 2 commits July 25, 2023 17:53

Merge branch 'master' into lazebnyi/2379-zendesk-support-handle-404-e…

56ae412

…rror

Updated version

9f54510

lazebnyi merged commit 8f92798 into master Jul 25, 2023

lazebnyi deleted the lazebnyi/2379-zendesk-support-handle-404-error branch July 25, 2023 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 Source Zendesk Support: Add handle 404 error #28397

🐛 Source Zendesk Support: Add handle 404 error #28397

Uh oh!

lazebnyi commented Jul 18, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited by lazebnyi

Loading

octavia-squidington-iii commented Jul 18, 2023

octavia-squidington-iii commented Jul 18, 2023

octavia-squidington-iii commented Jul 19, 2023

octavia-squidington-iii commented Jul 21, 2023

octavia-squidington-iii commented Jul 24, 2023

octavia-squidington-iii commented Jul 25, 2023

octavia-squidington-iii commented Jul 25, 2023

Labels

4 participants

🐛 Source Zendesk Support: Add handle 404 error #28397

🐛 Source Zendesk Support: Add handle 404 error #28397

Uh oh!

Conversation

lazebnyi commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

github-actions bot commented Jul 18, 2023 • edited by lazebnyi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

octavia-squidington-iii commented Jul 18, 2023

source-zendesk-support test report (commit e426f99e8c) - ❌

octavia-squidington-iii commented Jul 18, 2023

source-zendesk-support test report (commit 8b013d76af) - ❌

octavia-squidington-iii commented Jul 19, 2023

source-zendesk-support test report (commit 6e8b53c983) - ❌

octavia-squidington-iii commented Jul 21, 2023

source-zendesk-support test report (commit 0a689a428e) - ❌

octavia-squidington-iii commented Jul 24, 2023

source-zendesk-support test report (commit 529a284fa0) - ✅

octavia-squidington-iii commented Jul 25, 2023

source-zendesk-support test report (commit 56ae412ca0) - ✅

octavia-squidington-iii commented Jul 25, 2023

source-zendesk-support test report (commit 9f54510657) - ✅

Labels

4 participants

lazebnyi commented Jul 18, 2023 •

edited

Loading

github-actions bot commented Jul 18, 2023 •

edited by lazebnyi

Loading

source-zendesk-support test report (commit `e426f99e8c`) - ❌

source-zendesk-support test report (commit `8b013d76af`) - ❌

source-zendesk-support test report (commit `6e8b53c983`) - ❌

source-zendesk-support test report (commit `0a689a428e`) - ❌

source-zendesk-support test report (commit `529a284fa0`) - ✅

source-zendesk-support test report (commit `56ae412ca0`) - ✅

source-zendesk-support test report (commit `9f54510657`) - ✅