Skip to content

🐛 Source Github: update schema for Organizations stream #28144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2023
Merged

🐛 Source Github: update schema for Organizations stream #28144

merged 2 commits into from
Jul 11, 2023

Conversation

@arsenlosenko
Copy link
Contributor

@arsenlosenko arsenlosenko commented Jul 11, 2023

What

Fix failed CAT run for Source Github

How

  • Add property archived_at in stream organizations
  • Update expected records for stream organizations and repositories
@arsenlosenko arsenlosenko self-assigned this Jul 11, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github labels Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023 •
edited by arsenlosenko
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@arsenlosenko arsenlosenko marked this pull request as ready for review July 11, 2023 09:08
@octavia-squidington-iii
Copy link
Collaborator

octavia-squidington-iii commented Jul 11, 2023

source-github test report (commit 77170f6328) - ✅

⏲️ Total pipeline duration: 09mn48s

Step Result
Validate airbyte-integrations/connectors/source-github/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-github docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-github test
@octavia-squidington-iii
Copy link
Collaborator

octavia-squidington-iii commented Jul 11, 2023

source-github test report (commit 77170f6328) - ✅

⏲️ Total pipeline duration: 13mn41s

Step Result
Validate airbyte-integrations/connectors/source-github/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-github docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-github test
@arsenlosenko arsenlosenko merged commit 9cd5ee7 into master Jul 11, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-github-update-organizations-schema branch July 11, 2023 18:13
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@arsenlosenko @efimmatytsin
🐛 Source Github: update schema for Organizations stream (airbytehq#28144
95b871b 
) * Source Github: update schema for Organizations stream * Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/github

4 participants

@arsenlosenko @octavia-squidington-iii @lazebnyi