Skip to content

Source Google Ads: handle authorization error #27608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 22, 2023
Merged

Source Google Ads: handle authorization error #27608

merged 5 commits into from
Jun 22, 2023

Conversation

@artem1205
Copy link
Contributor

@artem1205 artem1205 commented Jun 22, 2023 •
edited
Loading

What

Resolving:

How

  • Fix pattern descriptor
  • handle authentication error

Recommended reading order

  1. y.python

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Jun 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 22, 2023
@artem1205 artem1205 marked this pull request as ready for review June 22, 2023 12:17
@octavia-squidington-iii
Copy link
Collaborator

octavia-squidington-iii commented Jun 22, 2023

source-google-ads test report (commit 0b9e3486ca) - ✅

⏲️ Total pipeline duration: 1039 seconds

Step Result
Validate airbyte-integrations/connectors/source-google-ads/metadata.yaml ✅
Connector version semver check. ✅
Connector version increment check. ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-google-ads docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-google-ads test
@artem1205 artem1205 requested a review from davydov-d June 22, 2023 12:37
@artem1205 artem1205 self-assigned this Jun 22, 2023
@artem1205 artem1205 requested a review from lazebnyi June 22, 2023 12:42
@artem1205 artem1205 merged commit aa9b4ee into master Jun 22, 2023
@artem1205 artem1205 deleted the artem1205/source-google-ads-oc-2162 branch June 22, 2023 16:34
@nataliekwong nataliekwong mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-ads

4 participants

@artem1205 @octavia-squidington-iii @lazebnyi