- Notifications
You must be signed in to change notification settings - Fork 4.9k
Source Stripe: Files and TopUps stream #27238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Stripe: Files and TopUps stream #27238
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
| /test connector=connectors/source-stripe
Build PassedTest summary info: |
| /test connector=connectors/source-stripe
Build PassedTest summary info: |
996cd3d to 20adb92 Compare |
| Step | Result |
|---|---|
| Validate airbyte-integrations/connectors/source-stripe/metadata.yaml | ✅ |
| Connector version semver check. | ✅ |
| Connector version increment check. | ✅ |
| QA checks | ✅ |
| Connector package install | ✅ |
| Build source-stripe docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-stripe test
bnchrch left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a REALLY well done PR.
- The description was informative about what changed (WITH LINKS!)
- The bypass reason that was added was clear.
Thank you this looks great to me.
What
next_page_tokenmethodifstatement that always returns TrueHow
Added new sterams: