Skip to content

Conversation

@roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Jun 12, 2023

What

How

Added new sterams:

  • TopUps (doc)
  • Files (doc)
  • FileLinks (doc)
  • Made refactoring
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe labels Jun 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source stripe files and top ups stream Source Stripe: Files and TopUps stream Jun 12, 2023
@roman-yermilov-gl roman-yermilov-gl self-assigned this Jun 12, 2023
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jun 13, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5260483646
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5260483646
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------ source_stripe/source.py 22 0 100% source_stripe/__init__.py 2 0 100% source_stripe/availability_strategy.py 19 2 89% source_stripe/streams.py 366 40 89% ------------------------------------------------------------ TOTAL 409 42 90% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first. ================== 39 passed, 2 skipped in 381.01s (0:06:21) =================== 
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jun 14, 2023

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5267055061
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/5267055061
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------ source_stripe/source.py 22 0 100% source_stripe/__init__.py 2 0 100% source_stripe/availability_strategy.py 19 2 89% source_stripe/streams.py 366 40 89% ------------------------------------------------------------ TOTAL 409 42 90% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first. ================== 39 passed, 2 skipped in 366.41s (0:06:06) =================== 
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-stripe-files-and-top_ups-stream branch from 996cd3d to 20adb92 Compare June 14, 2023 20:36
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 9479eb3040) - ✅

⏲️ Total pipeline duration: 373 seconds

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check.
Connector version increment check.
QA checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test
@roman-yermilov-gl roman-yermilov-gl enabled auto-merge (squash) June 14, 2023 23:08
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a REALLY well done PR.

  1. The description was informative about what changed (WITH LINKS!)
  2. The bypass reason that was added was clear.

Thank you this looks great to me.

@roman-yermilov-gl roman-yermilov-gl merged commit 6a87475 into master Jun 15, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-stripe-files-and-top_ups-stream branch June 15, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe

4 participants