Skip to content

Conversation

@roman-yermilov-gl
Copy link
Contributor

What

Expected records do not match. New field note added to board_pins stream.

How

Updated expected records and schema for stream board_pins

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@roman-yermilov-gl roman-yermilov-gl changed the title Ryermilov/source pinterest health check Source Pinterest: fix expected records Jun 2, 2023
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jun 2, 2023

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5155680428
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5155680428
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------- source_pinterest/utils.py 8 0 100% source_pinterest/__init__.py 2 0 100% source_pinterest/source.py 229 17 93% -------------------------------------------------- TOTAL 239 17 93% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first. ================== 49 passed, 3 skipped in 230.33s (0:03:50) =================== 
Copy link
Contributor

@davydov-d davydov-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the version and update the changelog

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jun 2, 2023
@roman-yermilov-gl
Copy link
Contributor Author

roman-yermilov-gl commented Jun 2, 2023

/test connector=connectors/source-pinterest

🕑 connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5158290905
✅ connectors/source-pinterest https://github.com/airbytehq/airbyte/actions/runs/5158290905
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------- source_pinterest/utils.py 8 0 100% source_pinterest/__init__.py 2 0 100% source_pinterest/source.py 229 17 93% -------------------------------------------------- TOTAL 239 17 93% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first. ================== 49 passed, 3 skipped in 243.22s (0:04:03) =================== 
@roman-yermilov-gl roman-yermilov-gl merged commit 0a63c45 into master Jun 2, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-pinterest-health-check branch June 2, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pinterest

4 participants