- Notifications
You must be signed in to change notification settings - Fork 4.9k
[non-forked] 🚨🚨Source Freshservice: correct data types in stream schemas to match Freshservice API #25743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… configure empty streams
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
| This PR corrects the following data types in the following schema files, which falls under a breaking change:
|
| /test connector=connectors/source-freshservice
Build PassedTest summary info: |
| /publish connector=connectors/source-freshservice
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…mas to match Freshservice API (airbytehq#25743) * Source Freshservice API: change field data type from integer to string to match API * Source Freshservice API: correct data types for phone number fields * Source Freshservice API: correct data types for phone number fields * add missing testing dependencies * remove unnecessary install * fix broken schema files, enable backwards_compatibility for 0.1.1 and configure empty streams * correct data types for requesters.json and bump dockerfile + readme * update source freshservice metadata.yaml * correct semantic versioning for major change * auto-bump connector version --------- Co-authored-by: Adam Roderick <aroder@gmail.com> Co-authored-by: Adam Roderick <23650+aroder@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
This PR includes the changes from #23945 and also includes changes to the schema files and acceptance_test_config.yml file to make tests pass.