Skip to content

Conversation

@sajarin
Copy link
Contributor

@sajarin sajarin commented May 1, 2023

This PR includes the changes from #23945 and also includes changes to the schema files and acceptance_test_config.yml file to make tests pass.

@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You, or an Airbyter, have run /publish successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)
  • The Octavia bot updated the source_definitions.yaml or destination_definitions.yaml, or you ran processResources manually (deprecated)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@sajarin sajarin changed the title Publish/Test #23945 [non-forked] 🐛 Source Freshservice: correct data types in stream schemas to match Freshservice API May 2, 2023
@sajarin sajarin changed the title [non-forked] 🐛 Source Freshservice: correct data types in stream schemas to match Freshservice API 🚨🚨[non-forked] 🐛 Source Freshservice: correct data types in stream schemas to match Freshservice API May 2, 2023
@sajarin sajarin changed the title 🚨🚨[non-forked] 🐛 Source Freshservice: correct data types in stream schemas to match Freshservice API [non-forked] 🚨🚨Source Freshservice: correct data types in stream schemas to match Freshservice API May 2, 2023
@sajarin sajarin added the breaking-change Don't merge me unless you are ready. label May 2, 2023
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 2, 2023
@sajarin
Copy link
Contributor Author

sajarin commented May 2, 2023

This PR corrects the following data types in the following schema files, which falls under a breaking change:

Ticket endpoint:
Category field should be string instead of integer

Requester endpoint:
work_phone_number should be string instead of integer
mobile_phone_number should be string instead of integer

Agent endpoint
work_phone_number should be string instead of integer
mobile_phone_number should be string instead of integer

@sajarin
Copy link
Contributor Author

sajarin commented May 2, 2023

/test connector=connectors/source-freshservice

🕑 connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/4864478356
✅ connectors/source-freshservice https://github.com/airbytehq/airbyte/actions/runs/4864478356
Python tests coverage:

Name Stmts Miss Cover ----------------------------------------------------- source_freshservice/source.py 26 0 100% source_freshservice/__init__.py 2 0 100% source_freshservice/streams.py 70 9 87% ----------------------------------------------------- TOTAL 98 9 91% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:587: Backward compatibility tests are disabled for version 0.1.1. ================= 39 passed, 1 skipped, 40 warnings in 28.65s ================== 
@sajarin
Copy link
Contributor Author

sajarin commented May 2, 2023

/publish connector=connectors/source-freshservice

🕑 Publishing the following connectors:
connectors/source-freshservice
https://github.com/airbytehq/airbyte/actions/runs/4864832365


Connector Version Did it publish? Were definitions generated?
connectors/source-freshservice 1.0.0

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@sajarin sajarin added checklist-action-run and removed breaking-change Don't merge me unless you are ready. checklist-action-run labels May 2, 2023
@sajarin sajarin merged commit 25c05f9 into master May 2, 2023
@sajarin sajarin deleted the source-freshservice-correct-data-type branch May 2, 2023 20:50
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…mas to match Freshservice API (airbytehq#25743) * Source Freshservice API: change field data type from integer to string to match API * Source Freshservice API: correct data types for phone number fields * Source Freshservice API: correct data types for phone number fields * add missing testing dependencies * remove unnecessary install * fix broken schema files, enable backwards_compatibility for 0.1.1 and configure empty streams * correct data types for requesters.json and bump dockerfile + readme * update source freshservice metadata.yaml * correct semantic versioning for major change * auto-bump connector version --------- Co-authored-by: Adam Roderick <aroder@gmail.com> Co-authored-by: Adam Roderick <23650+aroder@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/source/freshservice

4 participants