Skip to content

Conversation

@bibimorlet
Copy link
Contributor

@bibimorlet bibimorlet commented Apr 27, 2023

What

Closes #25620

  • The 'asset' Resource from Google Ads is not yet handled by the connector.

How

  • add 'asset' Resource in FULL_REFRESH_CUSTOM_TABLES

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@bibimorlet bibimorlet changed the title add 'asset' Resource tu full refresh custom tables Source Google Ads fix: add 'asset' Resource to full refresh custom tables Apr 27, 2023
@bibimorlet bibimorlet force-pushed the bibi/25620-source-google-ads branch from ac47066 to a9ddf0c Compare April 27, 2023 15:55
@bibimorlet bibimorlet changed the title Source Google Ads fix: add 'asset' Resource to full refresh custom tables Source Google Ads: add 'asset' Resource to full refresh custom tables Apr 27, 2023
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Apr 27, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/4822005868
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/4822005868
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------------------- source_google_ads/models.py 18 0 100% source_google_ads/__init__.py 2 0 100% source_google_ads/utils.py 56 1 98% source_google_ads/streams.py 195 6 97% source_google_ads/source.py 95 7 93% source_google_ads/custom_query_stream.py 56 5 91% source_google_ads/google_ads.py 73 12 84% -------------------------------------------------------------- TOTAL 495 31 94% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================== 39 passed, 2 skipped in 622.44s (0:10:22) =================== 
@bibimorlet bibimorlet changed the title Source Google Ads: add 'asset' Resource to full refresh custom tables 🐛 Source Google Ads: add 'asset' Resource to full refresh custom tables Apr 27, 2023
@bibimorlet
Copy link
Contributor Author

What should I do in order to make the "Add labels to github PRs based on context" check successful?

@sh4sh
Copy link
Contributor

sh4sh commented May 25, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5084438457
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5084438457
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================== 39 passed, 2 skipped in 659.41s (0:10:59) =================== 
@sh4sh sh4sh mentioned this pull request May 25, 2023
@jrolom jrolom removed the bounty label May 29, 2023
@sh4sh
Copy link
Contributor

sh4sh commented May 30, 2023

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5124220443
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/5124220443
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------------------- source_google_ads/models.py 18 0 100% source_google_ads/__init__.py 2 0 100% source_google_ads/utils.py 65 1 98% source_google_ads/streams.py 195 6 97% source_google_ads/source.py 95 7 93% source_google_ads/custom_query_stream.py 56 5 91% source_google_ads/google_ads.py 83 12 86% -------------------------------------------------------------- TOTAL 514 31 94% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================== 39 passed, 2 skipped in 576.41s (0:09:36) =================== 
@sh4sh sh4sh merged commit dab4cfc into airbytehq:master May 30, 2023
sh4sh added a commit to jpmmcneill/airbyte that referenced this pull request May 30, 2023
sh4sh added a commit that referenced this pull request May 30, 2023
…ng_group_filter" (#25314) * feat: new google ads full refresh custom table * bump version * update changelog * fix changelog date for last version #25624 --------- Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…es (airbytehq#25624) * add 'asset' Resource tu full refresh custom tables * update google-ads.md * remove diff hunk marker * update version in metadata.yaml --------- Co-authored-by: Sunny Hashmi <6833405+sh4sh@users.noreply.github.com>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
…ng_group_filter" (airbytehq#25314) * feat: new google ads full refresh custom table * bump version * update changelog * fix changelog date for last version airbytehq#25624 --------- Co-authored-by: sh4sh <6833405+sh4sh@users.noreply.github.com>
@bibimorlet bibimorlet deleted the bibi/25620-source-google-ads branch June 20, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/google-ads

7 participants