Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" #24890

grubberr · 2023-04-05T08:23:34Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md
- airbyte-integrations/builds.md
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Connector version has been incremented
- Version has been bumped according to our Semantic Versioning for Connectors guidelines
- Dockerfile has updated version
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-04-05T16:11:00Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4620558597
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4620558597
🐛 https://gradle.com/s/m2mf7qs5sm6ms

Build Failed

Test summary info:

 =========================== short test summary info ============================ FAILED unit_tests/test_streams.py::test_issue_property_keys_stream - assert 0... �[31m================== �[31m�[1m1 failed�[0m, �[32m55 passed�[0m, �[33m448 warnings�[0m�[31m in 1.37s�[0m�[31m ==================�[0m

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-04-05T19:07:10Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4621958912
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4621958912
🐛 https://gradle.com/s/f7svfoawh7qqu

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream appli... SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ============= 1 failed, 37 passed, 2 skipped in 695.12s (0:11:35) ==============

grubberr · 2023-04-06T20:13:51Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4632690985
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4632690985
🐛 https://gradle.com/s/o2x6am6u5y2ai

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream appli... SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ============= 1 failed, 37 passed, 2 skipped in 666.67s (0:11:06) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2023-04-07T07:19:15Z

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4636314523
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/4636314523
Python tests coverage:

Name Stmts Miss Cover --------------------------------------------- source_jira/utils.py 21 0 100% source_jira/__init__.py 2 0 100% source_jira/source.py 47 4 91% source_jira/streams.py 640 63 90% --------------------------------------------- TOTAL 710 67 91%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================== 38 passed, 2 skipped in 650.27s (0:10:50) ===================

grubberr · 2023-04-07T07:54:09Z

/publish connector=connectors/source-jira

🕑 Publishing the following connectors:
connectors/source-jira
https://github.com/airbytehq/airbyte/actions/runs/4636495348

Connector	Did it publish?	Were definitions generated?
connectors/source-jira	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

fix stream extract_field

6b9c030

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this Apr 5, 2023

octavia-squidington-iii added area/connectors Connector related issues connectors/source/jira labels Apr 5, 2023

bump 0.3.5

1c193fb

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr linked an issue Apr 5, 2023 that may be closed by this pull request

Source Jira: stream doesn't return data #24835

Closed

grubberr added 2 commits April 5, 2023 15:51

Merge branch 'master' into grubberr/24835-source-jira

7ef30e6

ScreenTabFields fixed

11899af

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr changed the title ~~Source Jira: fix streams~~ Source Jira: fix streams: IssuePropertyKeys, ScreenTabFields Apr 5, 2023

grubberr changed the title ~~Source Jira: fix streams: IssuePropertyKeys, ScreenTabFields~~ Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" Apr 5, 2023

jira.md updated

d4e2be6

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 5, 2023

issue_property_keys.json fixed

bc8a795

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 2 commits April 7, 2023 07:05

Merge branch 'master' into grubberr/24835-source-jira

2e6823e

re-generate records for application_roles stream

f576e16

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested review from lazebnyi and roman-yermilov-gl April 7, 2023 07:42

roman-yermilov-gl approved these changes Apr 7, 2023

View reviewed changes

davydov-d approved these changes Apr 7, 2023

View reviewed changes

auto-bump connector version

17e103f

grubberr merged commit be87246 into master Apr 7, 2023

grubberr deleted the grubberr/24835-source-jira branch April 7, 2023 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" #24890

Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" #24890

Uh oh!

grubberr commented Apr 5, 2023

grubberr commented Apr 5, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2023 •

edited by github-actions bot

Loading

Labels

5 participants

Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" #24890

Source Jira: fix streams "IssuePropertyKeys", "ScreenTabFields" #24890

Uh oh!

Conversation

grubberr commented Apr 5, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

grubberr commented Apr 5, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

grubberr commented Apr 5, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

grubberr commented Apr 6, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

grubberr commented Apr 7, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

grubberr commented Apr 7, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Labels

5 participants

grubberr commented Apr 5, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 5, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2023 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2023 •

edited by github-actions bot

Loading