Skip to content

Conversation

@mohamagdy
Copy link
Contributor

@mohamagdy mohamagdy commented Feb 28, 2023

To address the security fixes applied as recommended in an email sent from Paypal

What

Update braintree Python library to the latest version

How

Paypal sent us an email recommending updating to the version 4.17.1 or newer as they fixed some security issues.

🚨 User Impact 🚨

No user impact.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
To address the security fixes applied as recommended in an email sent from Paypal
@mohamagdy mohamagdy changed the title 🐛 Update braintree Python library to the latest version 🐛 Source Braintree: Update braintree Python library to the latest version Feb 28, 2023
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 13, 2023

/test connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/4405145218
❌ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/4405145218
🐛 https://gradle.com/s/ckjqhlp7qufmy

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream custo... SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical. ======= 1 failed, 35 passed, 1 skipped, 37 warnings in 65.88s (0:01:05) ======== 
@marcosmarxm
Copy link
Contributor

@mohamagdy I triggered integration tests. Can you bump the connector version and documentation?

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 13, 2023
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 13, 2023

/test connector=connectors/source-braintree

🕑 connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/4409004397
✅ connectors/source-braintree https://github.com/airbytehq/airbyte/actions/runs/4409004397
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------ source_braintree/streams.py 100 0 100% source_braintree/spec.py 32 0 100% source_braintree/source.py 18 0 100% source_braintree/schemas/transaction.py 99 0 100% source_braintree/schemas/subscription.py 35 0 100% source_braintree/schemas/plan.py 21 0 100% source_braintree/schemas/merchant_account.py 29 0 100% source_braintree/schemas/dispute.py 37 0 100% source_braintree/schemas/discount.py 13 0 100% source_braintree/schemas/customer.py 28 0 100% source_braintree/schemas/common.py 48 0 100% source_braintree/schemas/cards.py 86 0 100% source_braintree/schemas/__init__.py 8 0 100% source_braintree/__init__.py 2 0 100% ------------------------------------------------------------------ TOTAL 556 0 100% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical. ============ 36 passed, 1 skipped, 37 warnings in 62.14s (0:01:02) ============= 
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 13, 2023

/publish connector=connectors/source-braintree

🕑 Publishing the following connectors:
connectors/source-braintree
https://github.com/airbytehq/airbyte/actions/runs/4409090492


Connector Did it publish? Were definitions generated?
connectors/source-braintree

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm enabled auto-merge (squash) March 13, 2023 20:41
@marcosmarxm marcosmarxm merged commit 9257114 into airbytehq:master Mar 13, 2023
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
…ersion (airbytehq#23548) * Update `braintree` Python library to the latest version To address the security fixes applied as recommended in an email sent from Paypal * bump connector version * add eof * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…ersion (#23548) * Update `braintree` Python library to the latest version To address the security fixes applied as recommended in an email sent from Paypal * bump connector version * add eof * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
…ersion (#23548) * Update `braintree` Python library to the latest version To address the security fixes applied as recommended in an email sent from Paypal * bump connector version * add eof * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/braintree

3 participants