🎉Source MailChimp: New Stream Automations #23290

btkcodedev · 2023-02-21T17:03:50Z

What

Closes #17024

Enhancement

Adds a new stream:

Automations (Incremental)

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Issue acceptance criteria met
PR name follows PR naming conventions
Documentation that references the generator is updated as needed

For the reviewer:

New stream is working in my local system and all acceptance test passing
Please review & test it on the prod

btkcodedev · 2023-02-22T06:01:55Z

@YowanR could you please assign anyone for review

natalyjazzviolin · 2023-02-24T17:17:39Z

@btkcodedev Please make sure to run ./gradlew --no-daemon :airbyte-integrations:connectors:source-mailchimp:airbytePythonFormat to fix formatting errors.

natalyjazzviolin · 2023-02-24T21:21:37Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4266365963
❌ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4266365963
🐛 https://gradle.com/s/pr6nvlsw6b4vg

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0] FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs1] FAILED test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs2] FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0] FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs1] FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs2] FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0] FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs1] FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0] FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0] ======================== 10 failed, 52 passed in 45.52s ========================

btkcodedev · 2023-03-01T16:06:52Z

@natalyjazzviolin Thanks for the comments and build,
Primary keys, and cursor fields, all are updated and schema fixed.
Acceptance test is passing in local
Please continue the further review.

btkcodedev · 2023-03-16T16:00:14Z

Ready for review :)

btkcodedev · 2023-03-16T16:18:03Z

@natalyjazzviolin Bump Here :)

btkcodedev · 2023-04-01T17:59:57Z

@natalyjazzviolin @sh4sh @marcosmarxm @YowanR
The PR is ready for review,
Please could anyone run the test command :)

btkcodedev · 2023-04-01T18:03:27Z

The Docker version is set to 5.0 as the older version 3.5 was a stream update so considering it as a minor update rather than a patch,
Old -> 4.0 and now it's 5.0

marcosmarxm · 2023-04-02T10:17:05Z

Sorry @btkcodedev for the delay to review the contribution. @airbytehq/community-assistance-dri will review during this week.

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/spec.json

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py

sajarin · 2023-04-05T19:47:20Z

Hey thanks for the contribution and apologies for the delay!

I'll be the DRI responsible for reviewing this and getting it across the finish line. We currently have a backlog of about a dozen PRs, but just wanted to let you know that this PR has been added to the queue and I'll be trying my best to get to this as soon as possible.

Thanks for the contribution and for being patient :)

btkcodedev · 2023-04-07T15:18:27Z

Thanks, It is ready for review,
Please forward

marcosmarxm · 2023-04-11T20:05:13Z

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4671537838
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/4671537838
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------- source_mailchimp/__init__.py 2 0 100% source_mailchimp/source.py 46 1 98% source_mailchimp/streams.py 131 10 92% -------------------------------------------------- TOTAL 179 11 94%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. =================== 64 passed, 1 skipped in 71.95s (0:01:11) ===================

marcosmarxm

Thanks @btkcodedev I requested to the connector team to made the final review of the contribution. Hope to publish during the week.

btkcodedev · 2023-04-18T11:05:24Z

Thanks @marcosmarxm for update

btkcodedev · 2023-04-24T16:00:23Z

Thanks @arsenlosenko for approving the PR

marcosmarxm · 2023-04-24T17:03:46Z

/publish connector=connectors/source-mailchimp

🕑 Publishing the following connectors:
connectors/source-mailchimp
https://github.com/airbytehq/airbyte/actions/runs/4789047376

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-mailchimp	0.4.0	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* bump connector version * Source: MailChimp, New Stream Automations * fix: Schema error fix * Fixes formatting. * fix: Fixed acceptance test schema errors * fix: Update schema, update dockerlabel * refactor: Update docs * refactor: Update DockerVersionTag * fix: Update EOF and configured catalog * fix: Schema, Update docs * fix: Schema on catalog * fix: update DocketVersionTag * fix: schema, update docs, bump docker version * fix: spec, update doc in streams.py * fix: schema compatability for null * update connector version to 0.4.0 * Update Dockerfile * recreate source spec * restore source spec form main * rollback source spec from main * source spec * run gradle config seed * fix schema and remove unused code * fix docs * bump connector seed file versino * auto-bump connector version --------- Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: nataly <nataly@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>

octavia-squidington-iii added area/connectors Connector related issues bounty community connectors/source/mailchimp labels Feb 21, 2023

btkcodedev mentioned this pull request Feb 21, 2023

Source Mailchimp: new stream Automations #17024

Closed

YowanR requested review from natalyjazzviolin and sh4sh February 22, 2023 21:16

This comment was marked as outdated.

Sign in to view

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 16, 2023

marcosmarxm added the contributor-program PRs submitted through the contributor program. label Apr 2, 2023

marcosmarxm requested review from a team and removed request for natalyjazzviolin April 2, 2023 10:16

marcosmarxm suggested changes Apr 3, 2023

View reviewed changes

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/spec.json Outdated Show resolved Hide resolved

airbyte-integrations/connectors/source-mailchimp/source_mailchimp/streams.py Outdated Show resolved Hide resolved

btkcodedev requested a review from marcosmarxm April 4, 2023 21:21

marcosmarxm added the ga-connector-change label Apr 7, 2023

marcosmarxm assigned archangelic Apr 7, 2023

marcosmarxm force-pushed the enhanceMailchimp branch from 7a312f3 to e265487 Compare April 11, 2023 12:03

marcosmarxm and others added 2 commits April 11, 2023 13:35

bump connector version

aa0544f

Source: MailChimp, New Stream Automations

0dab095

btkcodedev and others added 11 commits April 11, 2023 16:11

fix: Schema, Update docs

0946e42

fix: Schema on catalog

3fc1a76

fix: update DocketVersionTag

ac56109

fix: schema, update docs, bump docker version

26d2f05

fix: spec, update doc in streams.py

6b5bf71

fix: schema compatability for null

e58daeb

update connector version to 0.4.0

a9a4b1d

Update Dockerfile

e1a8b1a

recreate source spec

cf42973

restore source spec form main

b923ab7

rollback source spec from main

0a793c7

marcosmarxm force-pushed the enhanceMailchimp branch from e9d3f7d to 0a793c7 Compare April 11, 2023 19:11

marcosmarxm added 5 commits April 11, 2023 16:12

source spec

742ed10

run gradle config seed

5d8d095

fix schema and remove unused code

e209697

fix docs

1ddbac7

bump connector seed file versino

18cce0e

marcosmarxm approved these changes Apr 11, 2023

View reviewed changes

marcosmarxm requested a review from arsenlosenko April 11, 2023 20:13

marcosmarxm self-assigned this Apr 17, 2023

marcosmarxm added the gl-review label Apr 17, 2023

arsenlosenko approved these changes Apr 24, 2023

View reviewed changes

octavia-squidington-iii and others added 2 commits April 24, 2023 17:16

auto-bump connector version

d67c90e

Merge branch 'master' into enhanceMailchimp

4582a47

marcosmarxm merged commit f6bd910 into airbytehq:master Apr 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🎉Source MailChimp: New Stream Automations #23290

🎉Source MailChimp: New Stream Automations #23290

Uh oh!

btkcodedev commented Feb 21, 2023 •

edited by natalyjazzviolin

Loading

btkcodedev commented Feb 22, 2023

natalyjazzviolin commented Feb 24, 2023

This comment was marked as outdated.

natalyjazzviolin commented Feb 24, 2023 •

edited by github-actions bot

Loading

btkcodedev commented Mar 1, 2023

btkcodedev commented Mar 16, 2023

btkcodedev commented Mar 16, 2023

btkcodedev commented Apr 1, 2023

btkcodedev commented Apr 1, 2023

marcosmarxm commented Apr 2, 2023

Uh oh!

Uh oh!

sajarin commented Apr 5, 2023

btkcodedev commented Apr 7, 2023

marcosmarxm commented Apr 11, 2023 •

edited by github-actions bot

Loading

marcosmarxm left a comment

btkcodedev commented Apr 18, 2023

btkcodedev commented Apr 24, 2023

marcosmarxm commented Apr 24, 2023 •

edited by github-actions bot

Loading

Labels

7 participants

🎉Source MailChimp: New Stream Automations #23290

🎉Source MailChimp: New Stream Automations #23290

Uh oh!

Conversation

btkcodedev commented Feb 21, 2023 • edited by natalyjazzviolin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Enhancement

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter [Yes]

For the reviewer:

btkcodedev commented Feb 22, 2023

natalyjazzviolin commented Feb 24, 2023

This comment was marked as outdated.

natalyjazzviolin commented Feb 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Failed

btkcodedev commented Mar 1, 2023

btkcodedev commented Mar 16, 2023

btkcodedev commented Mar 16, 2023

btkcodedev commented Apr 1, 2023

btkcodedev commented Apr 1, 2023

marcosmarxm commented Apr 2, 2023

Uh oh!

Uh oh!

sajarin commented Apr 5, 2023

btkcodedev commented Apr 7, 2023

marcosmarxm commented Apr 11, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

marcosmarxm left a comment

Choose a reason for hiding this comment

btkcodedev commented Apr 18, 2023

btkcodedev commented Apr 24, 2023

marcosmarxm commented Apr 24, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Labels

7 participants

btkcodedev commented Feb 21, 2023 •

edited by natalyjazzviolin

Loading

natalyjazzviolin commented Feb 24, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 11, 2023 •

edited by github-actions bot

Loading

marcosmarxm commented Apr 24, 2023 •

edited by github-actions bot

Loading