- Notifications
You must be signed in to change notification settings - Fork 4.9k
Source Klaviyo: adds stream Templates #23236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @YowanR This is ready to review. |
| @sajarin @marcosmarxm Can you please take a look? 🙏 |
marcosmarxm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/schemas/email_templates.json Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/schemas/email_templates.json Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-klaviyo/source_klaviyo/schemas/email_templates.json Outdated Show resolved Hide resolved
| @marcosmarxm I made the required changes. |
| /test connector=source-klaviyo
Build PassedTest summary info: |
marcosmarxm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @geekwhocodes
| @lazebnyi can you do the final review doing changes to a GA connector? |
lazebnyi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| /publish connector=connectors/source-klaviyo
if you have connectors that successfully published but failed definition generation, follow step 4 here |
What
Adds new stream
Templatesto the source Klaviyo mentioned in this issue #17392It uses existing HTTP Base Stream to include
templatesstream, read more here - https://developers.klaviyo.com/en/v1-2/reference/get-templatesRecommended reading order
y.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes