Skip to content

Conversation

@geekwhocodes
Copy link
Contributor

@geekwhocodes geekwhocodes commented Feb 18, 2023

What

Adds new stream Templates to the source Klaviyo mentioned in this issue #17392
It uses existing HTTP Base Stream to include templates stream, read more here - https://developers.klaviyo.com/en/v1-2/reference/get-templates

Recommended reading order

  1. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 18, 2023
@geekwhocodes geekwhocodes marked this pull request as ready for review March 15, 2023 14:17
@geekwhocodes
Copy link
Contributor Author

@YowanR This is ready to review.

@YowanR YowanR requested review from marcosmarxm and sajarin March 15, 2023 15:29
@YowanR
Copy link
Contributor

YowanR commented Mar 15, 2023

@sajarin @marcosmarxm Can you please take a look? 🙏

@YowanR YowanR requested a review from a team March 20, 2023 17:46
@YowanR YowanR added the contributor-program PRs submitted through the contributor program. label Mar 20, 2023
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@geekwhocodes
Copy link
Contributor Author

@marcosmarxm I made the required changes.

@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 24, 2023

/test connector=source-klaviyo

🕑 source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/4512079106
✅ source-klaviyo https://github.com/airbytehq/airbyte/actions/runs/4512079106
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------ source_klaviyo/__init__.py 2 0 100% source_klaviyo/streams.py 143 12 92% source_klaviyo/source.py 16 3 81% ------------------------------------------------ TOTAL 161 15 91% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical. =================== 40 passed, 1 skipped in 73.30s (0:01:13) =================== 
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geekwhocodes

@marcosmarxm marcosmarxm requested a review from lazebnyi March 24, 2023 14:18
@marcosmarxm
Copy link
Contributor

@lazebnyi can you do the final review doing changes to a GA connector?

Copy link
Contributor

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marcosmarxm
Copy link
Contributor

marcosmarxm commented Mar 31, 2023

/publish connector=connectors/source-klaviyo

🕑 Publishing the following connectors:
connectors/source-klaviyo
https://github.com/airbytehq/airbyte/actions/runs/4579041295


Connector Did it publish? Were definitions generated?
connectors/source-klaviyo

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm merged commit 7eea0ff into airbytehq:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/klaviyo contributor-program PRs submitted through the contributor program.

5 participants