Skip to content

Conversation

@itaseskii
Copy link
Contributor

@itaseskii itaseskii commented Feb 17, 2023

What

Adds new Azure Blob Storage source connector
#9374

How

Recommended reading order

  1. AzureBlobStorageConfig.java
  2. AzureBlobStorageSource,java
  3. AzureBlobStorageStateManager.java
  4. AzureBlobStorageOperations.java
  5. AzureBlob.java
  6. AzureBlobAdditionalProperties.java
  7. JsonlAzureBlobStorageOperations.java

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
@CLAassistant
Copy link

CLAassistant commented Feb 17, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ itaseskii
✅ sajarin
❌ itaseski


itaseski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-blob-storage labels Feb 17, 2023
@natalyjazzviolin
Copy link
Contributor

@itaseskii could you please:

  1. Make sure the CLA is signed by this account.
  2. Go through the new connector checklist in the main comment.
  3. Run intergration tests locally and include the logs.

Thanks!

@itaseskii
Copy link
Contributor Author

Screenshot_20230217_220003

@itaseskii
Copy link
Contributor Author

Hey @natalyjazzviolin

  1. Unfortunately I can't sign the CLA with my other account since it is not a Github account. This is not the first time this has happened since I change between repos/users frequently on my local machine.
  2. Done.
  3. I have posted an image of the passing acceptance tests.
@YowanR YowanR requested review from marcosmarxm and sajarin March 8, 2023 23:12
@YowanR
Copy link
Contributor

YowanR commented Mar 8, 2023

@sajarin Can you take a look, please?

@sajarin
Copy link
Contributor

sajarin commented Mar 8, 2023

Thanks for the contribution @itaseskii, I'll have an update for you either today or tomorrow, we'll get this merged soon!

@sajarin
Copy link
Contributor

sajarin commented Mar 13, 2023

Hey @itaseskii looks good, would you happen to have any test credentials you can share?

@itaseskii
Copy link
Contributor Author

Hey @itaseskii looks good, would you happen to have any test credentials you can share?

Hey @sajarin, you don't need testing credentials since the connector is using the Azurite emulator for azure blob storage in order to run the acceptance tests. https://github.com/airbytehq/airbyte/pull/23222/files#diff-c242ce3e6fe5cb0655d4c912a5bcd5beb1897fb242ccf8a3d98ced74e1115246

@itaseskii itaseskii closed this by deleting the head repository Mar 15, 2023
@marcosmarxm
Copy link
Contributor

@itaseskii any reasons to close the PR?

@itaseskii itaseskii reopened this Mar 15, 2023
@itaseskii
Copy link
Contributor Author

@itaseskii any reasons to close the PR?

@marcosmarxm It was a mistake on my side caused by deleting my fork. I have reopened it now.

@marcosmarxm marcosmarxm requested a review from a team March 17, 2023 14:27
@marcosmarxm marcosmarxm added contributor-program PRs submitted through the contributor program. community labels Mar 17, 2023
@marcosmarxm
Copy link
Contributor

/test connector=connectors/source-azure-blob-storage

@marcosmarxm
Copy link
Contributor

@itaseskii I'm closing this in favor of #24767 to publish the connector. Thanks for the contribution!

@marcosmarxm marcosmarxm closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/azure-blob-storage contributor-program PRs submitted through the contributor program.

7 participants