Skip to content

Conversation

@artem1205
Copy link
Contributor

What

Resolving https://github.com/airbytehq/oncall/issues/1513

How

Fix error handling

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
@artem1205
Copy link
Contributor Author

artem1205 commented Feb 17, 2023

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4205787428
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4205787428
🐛 https://gradle.com/s/wdw6j6m4l5k5a

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_incremental.py::TestIncremental::test_two_sequential_reads[inputs0] SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical. ============== 1 failed, 36 passed, 2 skipped in 85.24s (0:01:25) ============== 
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 17, 2023
@artem1205 artem1205 temporarily deployed to more-secrets February 17, 2023 17:31 — with GitHub Actions Inactive
@artem1205 artem1205 temporarily deployed to more-secrets February 17, 2023 17:31 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 27.16% 🍏
@artem1205
Copy link
Contributor Author

artem1205 commented Feb 17, 2023

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4206898064
✅ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/4206898064
Python tests coverage:

Name Stmts Miss Cover ----------------------------------------------------------- source_paypal_transaction/utils.py 8 0 100% source_paypal_transaction/__init__.py 2 0 100% source_paypal_transaction/source.py 275 13 95% ----------------------------------------------------------- TOTAL 285 13 95% Name Stmts Miss Cover Missing ------------------------------------------------------------------------------------- connector_acceptance_test/base.py 12 4 67% 16-19 connector_acceptance_test/config.py 142 5 96% 87, 93, 242, 246-247 connector_acceptance_test/conftest.py 220 102 54% 37, 43-45, 50, 55, 60, 83, 89, 95-97, 116, 121-123, 129-131, 137-138, 143-144, 149, 160, 169-178, 184-189, 204, 228, 259, 265, 273-281, 289-302, 310-323, 328-334, 341-352, 359-375 connector_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148 connector_acceptance_test/tests/test_core.py 476 117 75% 53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906 connector_acceptance_test/tests/test_incremental.py 162 14 91% 58-65, 70-83, 252 connector_acceptance_test/utils/asserts.py 39 2 95% 62-63 connector_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75 connector_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 connector_acceptance_test/utils/connector_runner.py 134 33 75% 30-33, 53-54, 57-61, 64-65, 80-82, 85-87, 90-92, 95-97, 100-102, 132-133, 167-169, 216 connector_acceptance_test/utils/json_schema_helper.py 114 13 89% 31-32, 39, 42, 66-69, 97, 121, 203-205 ------------------------------------------------------------------------------------- TOTAL 1716 348 80% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical. =================== 37 passed, 2 skipped in 99.14s (0:01:39) =================== 
@artem1205 artem1205 requested review from a team, bazarnov and lazebnyi February 17, 2023 19:37
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for allowed_hosts and no bypass reasons for connector tests!

@artem1205
Copy link
Contributor Author

artem1205 commented Feb 22, 2023

/publish connector=connectors/source-paypal-transaction

🕑 Publishing the following connectors:
connectors/source-paypal-transaction
https://github.com/airbytehq/airbyte/actions/runs/4247295107


Connector Did it publish? Were definitions generated?
connectors/source-paypal-transaction

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@artem1205 artem1205 merged commit 4ba8636 into master Feb 22, 2023
@artem1205 artem1205 deleted the artem1205/source-paypal-transaction-OC-1513 branch February 22, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/paypal-transaction

6 participants