Skip to content

Source Mailgun: Mark datefields in spec as dates #22939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 2, 2023
Merged

Source Mailgun: Mark datefields in spec as dates #22939

merged 6 commits into from
Mar 2, 2023

Conversation

@arsenlosenko
Copy link
Contributor

@arsenlosenko arsenlosenko commented Feb 13, 2023

What

Resolving:
#22743

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed
@arsenlosenko arsenlosenko self-assigned this Feb 13, 2023
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Feb 13, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailgun

🕑 connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/4165755766
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailgun labels Feb 13, 2023
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Feb 14, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailgun

🕑 connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/4172617996
✅ connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/4172617996
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------ source_mailgun/__init__.py 2 0 100% source_mailgun/source.py 104 4 96% ------------------------------------------------ TOTAL 106 4 96% Name Stmts Miss Cover Missing ------------------------------------------------------------------------------------- connector_acceptance_test/base.py 12 4 67% 16-19 connector_acceptance_test/config.py 141 5 96% 87, 93, 239, 243-244 connector_acceptance_test/conftest.py 217 101 53% 37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365 connector_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148 connector_acceptance_test/tests/test_core.py 476 117 75% 53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906 connector_acceptance_test/tests/test_incremental.py 162 14 91% 58-65, 70-83, 252 connector_acceptance_test/utils/asserts.py 39 2 95% 62-63 connector_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75 connector_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 connector_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208 connector_acceptance_test/utils/json_schema_helper.py 114 13 89% 31-32, 39, 42, 66-69, 97, 121, 203-205 ------------------------------------------------------------------------------------- TOTAL 1711 347 80%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical. ================= 36 passed, 1 skipped, 37 warnings in 50.17s ==================
@arsenlosenko arsenlosenko marked this pull request as ready for review February 14, 2023 11:03
lazebnyi
lazebnyi approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait code freeze end.
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Mar 2, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailgun

🕑 connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/4313373230
✅ connectors/source-mailgun https://github.com/airbytehq/airbyte/actions/runs/4313373230
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------ source_mailgun/__init__.py 2 0 100% source_mailgun/source.py 104 4 96% ------------------------------------------------ TOTAL 106 4 96%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical. ================= 36 passed, 1 skipped, 37 warnings in 45.53s ==================
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Mar 2, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mailgun

🕑 Publishing the following connectors:
connectors/source-mailgun
https://github.com/airbytehq/airbyte/actions/runs/4314395433


Connector Did it publish? Were definitions generated?
connectors/source-mailgun ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@arsenlosenko arsenlosenko merged commit e1f9905 into master Mar 2, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/source-mailgun-format-date branch March 2, 2023 14:07
jbfbell pushed a commit that referenced this pull request Mar 6, 2023
@arsenlosenko @octavia-squidington-iii @jbfbell
Source Mailgun: Mark datefields in spec as dates (#22939)
0ebf62c 
* Source Mailgun: Mark datefields in spec as dates * Update changelog * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
@arsenlosenko @octavia-squidington-iii @danielduckworth
Source Mailgun: Mark datefields in spec as dates (airbytehq#22939)
6a3a323 
* Source Mailgun: Mark datefields in spec as dates * Update changelog * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@jbfbell jbfbell mentioned this pull request Mar 15, 2023
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailgun

4 participants

@arsenlosenko @lazebnyi @octavia-squidington-iii