Source Mixpanel: Mark datefields in spec as dates #22936

arsenlosenko · 2023-02-13T16:40:41Z

What

Resolving:
#22745

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
- docs/integrations/README.md
- airbyte-integrations/builds.md
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

arsenlosenko · 2023-02-13T16:40:53Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4165696379

arsenlosenko · 2023-02-14T10:00:05Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4172591788

arsenlosenko · 2023-04-03T11:43:23Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4596253193

arsenlosenko · 2023-04-04T12:14:31Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4607589120
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4607589120
Python tests coverage:

Name Stmts Miss Cover ---------------------------------------------------------------- source_mixpanel/utils.py 8 0 100% source_mixpanel/streams/revenue.py 14 0 100% source_mixpanel/streams/funnels.py 57 0 100% source_mixpanel/streams/cohorts.py 15 0 100% source_mixpanel/streams/__init__.py 9 0 100% source_mixpanel/property_transformation.py 19 0 100% source_mixpanel/__init__.py 2 0 100% source_mixpanel/streams/base.py 93 3 97% source_mixpanel/streams/export.py 68 3 96% source_mixpanel/streams/engage.py 88 6 93% source_mixpanel/source.py 79 8 90% source_mixpanel/streams/annotations.py 16 3 81% source_mixpanel/streams/cohort_members.py 21 7 67% source_mixpanel/testing.py 29 11 62% ---------------------------------------------------------------- TOTAL 518 41 92%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================= 41 passed, 1 skipped in 13888.37s (3:51:28) ==================

arsenlosenko · 2023-04-05T06:14:44Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4615523774
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/4615523774
Python tests coverage:

Name Stmts Miss Cover ---------------------------------------------------------------- source_mixpanel/utils.py 8 0 100% source_mixpanel/streams/revenue.py 14 0 100% source_mixpanel/streams/funnels.py 57 0 100% source_mixpanel/streams/cohorts.py 15 0 100% source_mixpanel/streams/__init__.py 9 0 100% source_mixpanel/property_transformation.py 19 0 100% source_mixpanel/__init__.py 2 0 100% source_mixpanel/streams/base.py 93 3 97% source_mixpanel/streams/export.py 68 3 96% source_mixpanel/streams/engage.py 88 6 93% source_mixpanel/source.py 79 8 90% source_mixpanel/streams/annotations.py 16 3 81% source_mixpanel/streams/cohort_members.py 21 7 67% source_mixpanel/testing.py 29 11 62% ---------------------------------------------------------------- TOTAL 518 41 92%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical. ================= 41 passed, 1 skipped in 13878.31s (3:51:18) ==================

arsenlosenko · 2023-04-05T12:21:56Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/4618408044

Connector	Did it publish?	Were definitions generated?

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Source Mixpanel: Mark datefields in spec as dates

b0187bd

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mixpanel labels Feb 13, 2023

arsenlosenko and others added 2 commits February 13, 2023 18:41

Update changelog

13639c1

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

ed1a2e2

arsenlosenko marked this pull request as ready for review April 3, 2023 11:16

arsenlosenko self-assigned this Apr 3, 2023

arsenlosenko requested a review from lazebnyi April 3, 2023 11:16

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

cef765d

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

7a23bcb

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

6ec436d

lazebnyi approved these changes Apr 5, 2023

View reviewed changes

octavia-squidington-iii and others added 5 commits April 5, 2023 14:44

auto-bump connector version

68601ec

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

5a4b8f8

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

27f52f1

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

a679862

Merge branch 'master' into arsenlosenko/source-mixpanel-format-date

184bfa6

arsenlosenko merged commit b19b055 into master Apr 6, 2023

arsenlosenko deleted the arsenlosenko/source-mixpanel-format-date branch April 6, 2023 12:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Source Mixpanel: Mark datefields in spec as dates #22936

Source Mixpanel: Mark datefields in spec as dates #22936

Uh oh!

arsenlosenko commented Feb 13, 2023

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 5, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 5, 2023 •

edited by github-actions bot

Loading

Labels

4 participants

Source Mixpanel: Mark datefields in spec as dates #22936

Source Mixpanel: Mark datefields in spec as dates #22936

Uh oh!

Conversation

arsenlosenko commented Feb 13, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

arsenlosenko commented Feb 13, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

arsenlosenko commented Feb 14, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

arsenlosenko commented Apr 3, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

arsenlosenko commented Apr 4, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

arsenlosenko commented Apr 5, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Passed

arsenlosenko commented Apr 5, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Labels

4 participants

arsenlosenko commented Feb 13, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Feb 14, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 3, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 4, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 5, 2023 •

edited by github-actions bot

Loading

arsenlosenko commented Apr 5, 2023 •

edited by github-actions bot

Loading