Skip to content

Source Gitlab: unit tests #20479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 15, 2022
Merged

Source Gitlab: unit tests #20479

merged 5 commits into from
Dec 15, 2022

Conversation

@davydov-d
Copy link
Contributor

@davydov-d davydov-d commented Dec 14, 2022 •
edited
Loading

What

  • Unit tests coverage -> 95%
@davydov-d davydov-d linked an issue Dec 14, 2022 that may be closed by this pull request
Source Gitlab: increase unit test coverage to 90% #20371
Closed
@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 14, 2022
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 14, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab:dev

🕑 connectors/source-gitlab:dev https://github.com/airbytehq/airbyte/actions/runs/3696305180
❌ connectors/source-gitlab:dev https://github.com/airbytehq/airbyte/actions/runs/3696305180
🐛
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 14, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3696364110
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3696364110
🐛 https://gradle.com/s/btdup3b3p4wgq

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: All ... SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical. ======= 1 failed, 30 passed, 2 skipped, 31 warnings in 296.52s (0:04:56) ======= > Task :airbyte-integrations:connectors:source-gitlab:sourceAcceptanceTest FAILED Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness. Please consult deprecation warnings for more details. 48 actionable tasks: 23 executed, 25 up-to-date Publishing build scan... https://gradle.com/s/btdup3b3p4wgq The remote build cache was disabled during the build due to errors. S3 cache writes: 1, elapsed: 601ms, sent to cache: 448 B
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 14, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3698798652
❌ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3698798652
🐛 https://gradle.com/s/sqzmlpahxzmge

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream epic_... FAILED test_core.py::TestBasicRead::test_read[inputs1] - docker.errors.Contai... SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical. ======= 2 failed, 29 passed, 2 skipped, 31 warnings in 380.21s (0:06:20) ======= > Task :airbyte-integrations:connectors:source-gitlab:sourceAcceptanceTest FAILED Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0. You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins. See https://docs.gradle.org/7.6/userguide/command_line_interface.html#sec:command_line_warnings Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness. Please consult deprecation warnings for more details. 48 actionable tasks: 23 executed, 25 up-to-date Publishing build scan... https://gradle.com/s/sqzmlpahxzmge The remote build cache was disabled during the build due to errors. S3 cache writes: 1, elapsed: 590ms, sent to cache: 446 B
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 15, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3702387176
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/3702387176
Python tests coverage:

Name Stmts Miss Cover ----------------------------------------------- source_gitlab/__init__.py 2 0 100% source_gitlab/source.py 55 2 96% source_gitlab/streams.py 245 13 95% ----------------------------------------------- TOTAL 302 15 95% Name Stmts Miss Cover Missing ---------------------------------------------------------------------------------- source_acceptance_test/base.py 12 4 67% 16-19 source_acceptance_test/config.py 140 5 96% 87, 93, 238, 242-243 source_acceptance_test/conftest.py 208 92 56% 36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353 source_acceptance_test/plugin.py 69 25 64% 22-23, 31, 36, 120-140, 144-148 source_acceptance_test/tests/test_core.py 402 115 71% 53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776 source_acceptance_test/tests/test_incremental.py 158 14 91% 52-59, 64-77, 240 source_acceptance_test/utils/asserts.py 39 2 95% 62-63 source_acceptance_test/utils/common.py 94 10 89% 16-17, 32-38, 72, 75 source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 source_acceptance_test/utils/connector_runner.py 133 33 75% 24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208 source_acceptance_test/utils/json_schema_helper.py 107 13 88% 30-31, 38, 41, 65-68, 96, 120, 192-194 ---------------------------------------------------------------------------------- TOTAL 1603 336 79%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical. SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical. ============ 31 passed, 2 skipped, 31 warnings in 244.71s (0:04:04) ============
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 15, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3702713629


Connector Did it publish? Were definitions generated?
connectors/source-gitlab ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@davydov-d
Copy link
Contributor Author

davydov-d commented Dec 15, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 Publishing the following connectors:
connectors/source-gitlab
https://github.com/airbytehq/airbyte/actions/runs/3703200990


Connector Did it publish? Were definitions generated?
connectors/source-gitlab ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 10:52 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 10:52 — with GitHub Actions Inactive
@davydov-d davydov-d merged commit 8f1f90a into master Dec 15, 2022
@davydov-d davydov-d deleted the ddavydov/#20371-source-gitlab-unittests branch December 15, 2022 11:01
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab

6 participants

@davydov-d @arsenlosenko @bazarnov @octavia-squidington-iii @octavia-squidington-iv