Skip to content

Source Gridly: add icon and make grid_id parameter required #20048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2022
Merged

Source Gridly: add icon and make grid_id parameter required #20048

merged 5 commits into from
Dec 8, 2022

Conversation

@hntan
Copy link
Contributor

@hntan hntan commented Dec 4, 2022

Add icon for source-gridly
Mark grid_id as required field
@hntan hntan requested a review from a team December 4, 2022 08:27
@CLAassistant
Copy link

CLAassistant commented Dec 4, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Dec 5, 2022

@hntan can you sign the CLA or check the user you submit the change?
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Dec 5, 2022

@hntan would be possible to find a bigger icon?
@sajarin sajarin added internal and removed bounty labels Dec 5, 2022
@hntan
Copy link
Contributor Author

hntan commented Dec 7, 2022

@hntan can you sign the CLA or check the user you submit the change?

Signed, I was accidentally using my company email but login Github with personal account.
@hntan
Copy link
Contributor Author

hntan commented Dec 7, 2022

@hntan would be possible to find a bigger icon?

Yes, added new bigger icon. Can you help to have a a look again?
marcosmarxm
marcosmarxm approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@marcosmarxm marcosmarxm changed the title Add icon for source-gridly Source Gridly: add icon and make grid_id parameter required Dec 7, 2022
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Dec 7, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gridly

🕑 Publishing the following connectors:
connectors/source-gridly
https://github.com/airbytehq/airbyte/actions/runs/3641168275


Connector Did it publish? Were definitions generated?
connectors/source-gridly ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@marcosmarxm
Copy link
Contributor

marcosmarxm commented Dec 8, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gridly

🕑 Publishing the following connectors:
connectors/source-gridly
https://github.com/airbytehq/airbyte/actions/runs/3649397059


Connector Did it publish? Were definitions generated?
connectors/source-gridly ✅ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
marcosmarxm
marcosmarxm approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hntan
@marcosmarxm marcosmarxm merged commit d64c9b6 into airbytehq:master Dec 8, 2022
@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues community connectors/source/gridly internal

5 participants

@hntan @CLAassistant @marcosmarxm @sajarin @octavia-squidington-iv