Skip to content

Record replication stats as part of trace #18909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2022
Merged

Record replication stats as part of trace #18909

merged 3 commits into from
Nov 3, 2022

Conversation

@jdpgrailsdev
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev commented Nov 3, 2022

What

  • Improve visibility into replication syncs

How

  • Record the number of bytes/records synced with each trace to improve visibility into performance of replication.

Recommended reading order

  1. ReplicationActivityImpl.java

Tests

  • Project builds locally
  • All tests pass

cc: @cgardens
@github-actions github-actions bot added area/platform issues related to the platform area/worker Related to worker labels Nov 3, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 3, 2022 14:32 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 3, 2022 15:03 Inactive
colesnodgrass
colesnodgrass approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@colesnodgrass colesnodgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple recommendations, otherwise 👍🏻
airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/ReplicationActivityImpl.java Outdated
}

private static void traceReplicationSummary(final ReplicationAttemptSummary replicationSummary) {
if (replicationSummary != null) {
Copy link
Member

@colesnodgrass colesnodgrass Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could flip this around to avoid some of this nesting:

if (replicationSummary == null) { return; }
Copy link
Contributor Author

@jdpgrailsdev jdpgrailsdev Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix
airbyte-workers/src/main/java/io/airbyte/workers/temporal/sync/ReplicationActivityImpl.java Outdated
if (replicationSummary.getStatus() != null) {
tags.put(REPLICATION_STATUS_KEY, replicationSummary.getStatus().value());
}
if (CollectionUtils.isNotEmpty(tags)) {
Copy link
Member

@colesnodgrass colesnodgrass Nov 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not if (!tags.isEmpty()) instead of bringing in a dependency for this one method that simply delegates to calling !isEmpty anyways:

public static boolean isNotEmpty(@Nullable Collection collection) { return collection != null && !collection.isEmpty(); }

As tags was created in this block of code, there isn't a chance for it being null. The null check in the isNotEmpty method is not providing anything.
Copy link
Contributor Author

@jdpgrailsdev jdpgrailsdev Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not if (!tags.isEmpty()) instead of bringing in dependency for this one method that simply delegates to calling !isEmpty anyways:

public static boolean isNotEmpty(@Nullable Collection collection) { return collection != null && !collection.isEmpty(); }

As tags was created in this block of code, there isn't a chance for it being null. The null check in the isNotEmpty method is not providing anything.

Will switch. I added that before I made tags not be nullable. That was the only reason for using it (avoiding a potential NPE).
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 3, 2022 16:01 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 9777797 into master Nov 3, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/replication-stats-apm-trace branch November 3, 2022 16:04
girarda pushed a commit that referenced this pull request Nov 3, 2022
@jdpgrailsdev
Record replication stats as part of trace (#18909)
fad7ff2 
* Record replication stats as part of trace * PR feedback
girarda pushed a commit that referenced this pull request Nov 3, 2022
@jdpgrailsdev
Record replication stats as part of trace (#18909)
2dec269 
* Record replication stats as part of trace * PR feedback
cgardens
cgardens reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo! excited for the data this gives us make better decisions!
mlavoie-sm360 pushed a commit to mlavoie-sm360/airbyte that referenced this pull request Nov 8, 2022
@jdpgrailsdev @mlavoie-sm360
Record replication stats as part of trace (airbytehq#18909)
ed0257c 
* Record replication stats as part of trace * PR feedback
mlavoie-sm360 pushed a commit to mlavoie-sm360/airbyte that referenced this pull request Nov 8, 2022
@jdpgrailsdev @mlavoie-sm360
Record replication stats as part of trace (airbytehq#18909)
33dd34b 
* Record replication stats as part of trace * PR feedback
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/platform issues related to the platform area/worker Related to worker

4 participants

@jdpgrailsdev @colesnodgrass @cgardens