Skip to content

source-instagram: migrate to per-stream state #17110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 28, 2022
Merged

source-instagram: migrate to per-stream state #17110

merged 6 commits into from
Sep 28, 2022

Conversation

@alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Sep 23, 2022

What

  • Migrate source-instagram to per-stream state

How

  • Remove read override which was used for backward compatibility one year from now.
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 23, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented Sep 23, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-instagram

🕑 connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3115649982
✅ connectors/source-instagram https://github.com/airbytehq/airbyte/actions/runs/3115649982
Python tests coverage:

Name Stmts Miss Cover -------------------------------------------------- source_instagram/__init__.py 2 0 100% source_instagram/api.py 59 5 92% source_instagram/source.py 31 11 65% source_instagram/streams.py 203 93 54% source_instagram/common.py 36 22 39% -------------------------------------------------- TOTAL 331 131 60% Name Stmts Miss Cover -------------------------------------------------- source_instagram/source.py 31 0 100% source_instagram/__init__.py 2 0 100% source_instagram/common.py 36 3 92% source_instagram/streams.py 203 19 91% source_instagram/api.py 59 7 88% -------------------------------------------------- TOTAL 331 29 91% Name Stmts Miss Cover Missing ---------------------------------------------------------------------------------- source_acceptance_test/base.py 10 4 60% 15-18 source_acceptance_test/config.py 83 6 93% 78-80, 84-86 source_acceptance_test/conftest.py 164 164 0% 6-282 source_acceptance_test/plugin.py 48 48 0% 6-104 source_acceptance_test/tests/test_core.py 329 111 66% 39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577 source_acceptance_test/tests/test_full_refresh.py 52 2 96% 34, 65 source_acceptance_test/tests/test_incremental.py 152 26 83% 21-23, 29-31, 36-43, 48-61, 239, 250-258 source_acceptance_test/utils/asserts.py 37 2 95% 57-58 source_acceptance_test/utils/common.py 77 17 78% 15-16, 24-30, 47-54, 64, 67 source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 source_acceptance_test/utils/connector_runner.py 112 50 55% 23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149 source_acceptance_test/utils/json_schema_helper.py 105 13 88% 30-31, 38, 41, 65-68, 96, 120, 190-192 ---------------------------------------------------------------------------------- TOTAL 1358 466 66%

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config ================== 26 passed, 1 skipped in 369.42s (0:06:09) ===================
alafanechere
alafanechere commented Sep 25, 2022
View reviewed changes
airbyte-integrations/connectors/source-instagram/Dockerfile
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.11
LABEL io.airbyte.version=1.0.0
Copy link
Contributor Author

@alafanechere alafanechere Sep 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping to 1.0.0 because I think the logic of updating the state structure introduced one year ago can now be deprecated.
@alafanechere alafanechere marked this pull request as ready for review September 25, 2022 11:04
@alafanechere alafanechere changed the title source-instagram: migrate to per stream source-instagram: migrate to per-stream state Sep 25, 2022
@alafanechere alafanechere mentioned this pull request Sep 25, 2022
Closed
@alafanechere
Copy link
Contributor Author

alafanechere commented Sep 28, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-instagram

🕑 Publishing the following connectors:
connectors/source-instagram
https://github.com/airbytehq/airbyte/actions/runs/3144134693


Connector Did it publish? Were definitions generated?
connectors/source-instagram ✅ ✅
@alafanechere alafanechere merged commit f006edb into master Sep 28, 2022
@alafanechere alafanechere deleted the augustin/upgrade-insta-to-per-stream branch September 28, 2022 14:52
@alafanechere alafanechere mentioned this pull request Sep 28, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 28, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@alafanechere @robbinhan
source-instagram: migrate to per-stream state (airbytehq#17110)
ec09c9a
@alafanechere alafanechere mentioned this pull request Sep 29, 2022
Closed
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@alafanechere @jhammarstedt
source-instagram: migrate to per-stream state (airbytehq#17110)
7d8283e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/instagram

5 participants

@alafanechere @girarda @pedroslopez @octavia-squidington-iii