Only STATE and RECORD messages from the Source should be sent to the Destination #16418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added area/platform 
evantahler commented Sep 8, 2022
evantahler commented Sep 8, 2022
airbyte-workers/src/test/java/io/airbyte/workers/general/DefaultReplicationWorkerTest.java Outdated Show resolved Hide resolved
evantahler force-pushed the evan/only-some-message-to-destination branch from c98afd3 to 58c7981 Compare evantahler requested review from benmoriceau, cgardens, davinchia and lmossman 
lmossman approved these changes Sep 9, 2022
Contributor
lmossman left a comment
lmossman left a comment There was a problem hiding this comment.
Looks reasonable to me!
davinchia approved these changes Sep 9, 2022
Contributor
davinchia left a comment
davinchia left a comment There was a problem hiding this comment.
Love the idea of being strict with message passing.
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
…Destination (airbytehq#16418) * Only STATE and RECORD messages from the Source should be sent to the Destination * add test * update mocks * fixup tests * revert mock changes
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
…Destination (airbytehq#16418) * Only STATE and RECORD messages from the Source should be sent to the Destination * add test * update mocks * fixup tests * revert mock changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per the Airbyte Protocol, only STATE and RECORD messages from sources should be sent to destinations. LOG and TRACE messages should not be forwarded. Prior to this PR, TRACE and sometimes LOG messages could be sent to destination from the source.
Closes #16417