Skip to content

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 2, 2022
Merged

🐛 Avro compatible destinations: fix field name clashing with combined restrict #16243

merged 23 commits into from
Sep 2, 2022

Conversation

@tuliren
Copy link
Contributor

@tuliren tuliren commented Sep 1, 2022 •
edited
Loading

What

Version bumps

Destination Connector Old New
destination-redshift 0.3.48 0.3.49
destination-bigquery-denormalized 1.1.15 1.1.16
destination-snowflake 0.4.34 0.4.35
destination-s3 0.3.14 0.3.15
destination-bigquery 1.1.15 1.1.16
destination-gcs 0.2.10 0.2.11
destination-databricks 0.2.6 unpublished
@github-actions github-actions bot added the area/connectors Connector related issues label Sep 1, 2022
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022 •
edited by tuliren
Loading

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-jdbc
  • destination-redshift
  • destination-bigquery-denormalized
  • destination-snowflake
  • destination-s3
  • destination-bigquery
  • destination-gcs
  • destination-databricks
@github-actions

This comment was marked as outdated.

Sign in to view
@tuliren
Revert "Bump dest jdbc"
f84a5bb 
This reverts commit f10497e.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-gcs
  • destination-redshift
  • destination-snowflake
  • destination-databricks
  • destination-jdbc
  • destination-bigquery-denormalized
  • destination-s3
@tuliren

This comment was marked as outdated.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-redshift
  • destination-snowflake
  • destination-databricks
  • destination-gcs
  • destination-s3
  • destination-bigquery-denormalized
  • destination-jdbc
@tuliren tuliren temporarily deployed to more-secrets September 1, 2022 23:13 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Sep 1, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-s3,connectors/destination-gcs,connectors/destination-redshift,connectors/destination-bigquery,connectors/destination-bigquery-denormalized,connectors/destination-snowflake,connectors/destination-databricks

🕑 Publishing the following connectors:
connectors/destination-s3,connectors/destination-gcs,connectors/destination-redshift,connectors/destination-bigquery,connectors/destination-bigquery-denormalized,connectors/destination-snowflake,connectors/destination-databricks
https://github.com/airbytehq/airbyte/actions/runs/2975613615


Connector Did it publish? Were definitions generated?
connectors/destination-gcs ✅ ✅
connectors/destination-s3 ✅ ✅
connectors/destination-bigquery-denormalized ✅ ✅
connectors/destination-redshift ✅ ✅
connectors/destination-bigquery ✅ ✅
connectors/destination-databricks ❌ ❌
connectors/destination-snowflake ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-databricks
  • destination-gcs
  • destination-bigquery-denormalized
  • destination-s3
  • destination-redshift
  • destination-bigquery
  • destination-jdbc
  • destination-snowflake
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:03 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-jdbc
  • destination-bigquery-denormalized
  • destination-redshift
  • destination-snowflake
  • destination-gcs
  • destination-databricks
  • destination-s3
  • destination-bigquery
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-bigquery
  • destination-databricks
  • destination-snowflake
  • destination-gcs
  • destination-redshift
  • destination-jdbc
  • destination-s3
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:07 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-redshift
  • destination-bigquery
  • destination-bigquery-denormalized
  • destination-databricks
  • destination-jdbc
  • destination-snowflake
  • destination-gcs
  • destination-s3
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:14 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented Sep 2, 2022

Databricks integration test failed. Will exclude it from the publication for now.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery-denormalized
  • destination-redshift
  • destination-jdbc
  • destination-bigquery
  • destination-gcs
  • destination-snowflake
  • destination-databricks
  • destination-s3
@tuliren tuliren temporarily deployed to more-secrets September 2, 2022 00:33 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • destination-bigquery
  • destination-snowflake
  • destination-databricks
  • destination-gcs
  • destination-redshift
  • destination-bigquery-denormalized
  • destination-jdbc
  • destination-s3
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets September 2, 2022 00:55 Inactive
@tuliren tuliren marked this pull request as ready for review September 2, 2022 01:05
@tuliren tuliren requested a review from a team as a code owner September 2, 2022 01:05
@tuliren tuliren merged commit fd547c6 into master Sep 2, 2022
@tuliren tuliren deleted the liren/publish-s3 branch September 2, 2022 01:06
@tuliren tuliren mentioned this pull request Sep 2, 2022
Merged
37 tasks
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 2, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@tuliren @octavia-squidington-iii @robbinhan
🐛 Avro related destinations: fix field name clashing with combined re…
3ddfd0a 
…strict (airbytehq#16243) * Add test case for allOf and oneOf * Bump version * Add pr id * Bump gcs version * Bump dest jdbc * Bump redshift * Bump snowflake * Bump databricks * Bump bigquery * Revert "Bump dest jdbc" This reverts commit f10497e. * Use a new pat to avoid api rate limit * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * Revert databricks bump * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@tuliren @octavia-squidington-iii @jhammarstedt
🐛 Avro related destinations: fix field name clashing with combined re…
95783b1 
…strict (airbytehq#16243) * Add test case for allOf and oneOf * Bump version * Add pr id * Bump gcs version * Bump dest jdbc * Bump redshift * Bump snowflake * Bump databricks * Bump bigquery * Revert "Bump dest jdbc" This reverts commit f10497e. * Use a new pat to avoid api rate limit * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * auto-bump connector version [ci skip] * Revert databricks bump * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destination/databricks connectors/destination/gcs connectors/destination/jdbc connectors/destination/redshift connectors/destination/s3 connectors/destination/snowflake

3 participants

@tuliren @octavia-squidington-iii