Move 'updateNew' logic into 'update', and remove 'updateNew' #15863
Conversation
github-actions bot added area/api 
lmossman force-pushed the lmossman/remove-update-new branch from 317c0f3 to 4204c15 Compare 
| | ||
| @Test | ||
| void testResetAllWhenSchemaIsModified() throws Exception { | ||
| void testResetAllWhenSchemaIsModifiedForLegacySource() throws Exception { |
There was a problem hiding this comment.
I had to update this test to explicitly use a legacy postgres source that does not support per-stream, since that is the scenario in which all streams are reset as a result of a schema modification
lmossman requested review from alovew, gosusnp and timroes and removed request for a team 
| } | ||
| | ||
| @Test | ||
| void testUpdateConnectionWithOperationsNew() throws JsonValidationException, ConfigNotFoundException, IOException { |
There was a problem hiding this comment.
nit: can we remove 'new' from this test name?
| This looks good to me - I think we'll also want to update cloud to remove the updateNew endpoint from |
krishnaglick left a comment
krishnaglick left a comment There was a problem hiding this comment.
LGTM for frontend changes
Yep, I have a PR for that ready to go here: https://github.com/airbytehq/airbyte-cloud/pull/2441 |
* save * clean up more usages and remove withRefreshedCatalog * make webapp use correct endpoint * add back intercept * fix acceptance test * fix log * remove 'new' from test name
What
Resolves #14733
How
This PR moves the logic from the connection
updateNewendpoint intoupdate, since only the new endpoint is now being used in production.This PR also involves replacing usages of
updateNewwithupdateand fixing tests.Recommended reading order
🚨 User Impact 🚨
There should be no user impact resulting from this change