Bigquery Destinatioin throw exception if job failed

[VitaliiMaltsev]

What

As seen here

airbyte/airbyte-integrations/connectors/destination-bigquery/src/main/java/io/airbyte/integrations/destination/bigquery/BigQueryGcsOperations.java

Lines 137 to 142 in 316a124

	try {
	BigQueryUtils.waitForJobFinish(loadJob);
	LOGGER.info("[{}] Tmp table {} (dataset {}) is successfully appended with staging files", loadJob.getJobId(), tmpTableId, datasetId);
	} catch (final BigQueryException | InterruptedException e) {
	LOGGER.error(String.format("[%s] Failed to upload staging files to tmp table %s (%s)", loadJob.getJobId(), tmpTableId, datasetId), e);
	}

This catch clause should throw an exception in addition to just logging a message; currently if the GCS load operation fails, the sync will still be marked as succeeded, even though no data was actually loaded into BigQuery.

How

replace logging message with throwing exception

Recommended reading order

1. x.java

🚨 User Impact 🚨

none

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

• Community member? Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • docs/integrations/README.md
  • airbyte-integrations/builds.md
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub by running the /publish command described here
• After the connector is published, connector added to connector index as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

[VitaliiMaltsev]

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2888815174
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2888815174
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------------------- normalization/transform_config/__init__.py 2 0 100% normalization/transform_catalog/reserved_keywords.py 13 0 100% normalization/transform_catalog/__init__.py 2 0 100% normalization/destination_type.py 13 0 100% normalization/__init__.py 4 0 100% normalization/transform_catalog/destination_name_transformer.py 157 8 95% normalization/transform_catalog/table_name_registry.py 174 34 80% normalization/transform_config/transform.py 186 49 74% normalization/transform_catalog/utils.py 51 14 73% normalization/transform_catalog/dbt_macro.py 22 7 68% normalization/transform_catalog/catalog_processor.py 147 80 46% normalization/transform_catalog/transform.py 61 38 38% normalization/transform_catalog/stream_processor.py 589 394 33% ------------------------------------------------------------------------------------- TOTAL 1421 624 56% 

Build Passed

Test summary info:

All Passed 

[VitaliiMaltsev]

/publish connector=connectors/destination-bigquery

[VitaliiMaltsev]

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/2909431408

Connector	Did it publish?	Were definitions generated?
connectors/destination-bigquery	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️