🎉 Source Facebook Marketing: Added custom conversions stream

[mlavoie-sm360]

What

Solves issue #15723 by adding a custom conversions stream

How

Added required schema and stream.

User Impact

No breaking changes. Adds support for new stream.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

[marcosmarxm]

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2876861043
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2876861043
🐛 https://gradle.com/s/zhr7l3vfqbwo4

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so... ================== 1 failed, 28 passed in 1686.47s (0:28:06) =================== 

[sajarin]

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2884120547
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2884120547
🐛 https://gradle.com/s/fpzc4t5ajttvq

Build Failed

Test summary info:

=========================== short test summary info ============================ FAILED test_core.py::TestDiscovery::test_backward_compatibility[inputs0] - so... ================== 1 failed, 28 passed in 1767.96s (0:29:27) =================== 

[mlavoie-sm360]

What is the process for changes to be merged? Should I be doing something else at this point in the process?

[marcosmarxm]

/test connector=connectors/source-facebook-marketing

[marcosmarxm]

What is the process for changes to be merged? Should I be doing something else at this point in the process?

I rebased your branch with master to solve the test issue. Let's see the latest /test run

[marcosmarxm]

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2952048816
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/2952048816
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------------- source_facebook_marketing/streams/__init__.py 2 0 100% source_facebook_marketing/spec.py 37 0 100% source_facebook_marketing/__init__.py 2 0 100% source_facebook_marketing/api.py 96 12 88% source_facebook_marketing/streams/base_streams.py 128 27 79% source_facebook_marketing/streams/common.py 40 13 68% source_facebook_marketing/source.py 42 16 62% source_facebook_marketing/streams/streams.py 117 45 62% source_facebook_marketing/utils.py 25 10 60% source_facebook_marketing/streams/base_insight_streams.py 132 54 59% source_facebook_marketing/streams/async_job.py 214 134 37% source_facebook_marketing/streams/async_job_manager.py 78 60 23% ------------------------------------------------------------------------------- TOTAL 913 371 59% Name Stmts Miss Cover ------------------------------------------------------------------------------- source_facebook_marketing/utils.py 25 0 100% source_facebook_marketing/streams/common.py 40 0 100% source_facebook_marketing/streams/async_job.py 214 0 100% source_facebook_marketing/streams/__init__.py 2 0 100% source_facebook_marketing/spec.py 37 0 100% source_facebook_marketing/__init__.py 2 0 100% source_facebook_marketing/source.py 42 1 98% source_facebook_marketing/streams/async_job_manager.py 78 3 96% source_facebook_marketing/api.py 96 9 91% source_facebook_marketing/streams/base_insight_streams.py 132 13 90% source_facebook_marketing/streams/streams.py 117 27 77% source_facebook_marketing/streams/base_streams.py 128 30 77% ------------------------------------------------------------------------------- TOTAL 913 83 91% Name Stmts Miss Cover Missing ---------------------------------------------------------------------------------- source_acceptance_test/base.py 10 4 60% 15-18 source_acceptance_test/config.py 83 6 93% 78-80, 84-86 source_acceptance_test/conftest.py 164 164 0% 6-282 source_acceptance_test/plugin.py 48 48 0% 6-104 source_acceptance_test/tests/test_core.py 329 111 66% 39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577 source_acceptance_test/tests/test_full_refresh.py 52 2 96% 34, 65 source_acceptance_test/tests/test_incremental.py 121 25 79% 21-23, 29-31, 36-43, 48-61, 208-216 source_acceptance_test/utils/asserts.py 37 2 95% 57-58 source_acceptance_test/utils/common.py 77 17 78% 15-16, 24-30, 47-54, 64, 67 source_acceptance_test/utils/compare.py 62 23 63% 21-51, 68, 97-99 source_acceptance_test/utils/connector_runner.py 110 48 56% 23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146 source_acceptance_test/utils/json_schema_helper.py 105 13 88% 30-31, 38, 41, 65-68, 96, 120, 190-192 ---------------------------------------------------------------------------------- TOTAL 1322 463 65% 

Build Passed

Test summary info:

All Passed 

[marcosmarxm]

@lazebnyi can you do the final review for this community contribution?

[marcosmarxm]

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2974373675

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[marcosmarxm]

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/2975145386

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[marcosmarxm]

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/3003138421

Connector	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️