Skip to content

Conversation

@annalvova05
Copy link
Contributor

@annalvova05 annalvova05 commented Jul 14, 2022

What

OAuth2.0 authorization method
okta-1
okta-3

How

Add oauth flow authorization.

Recommended reading order

  1. spec.py
  2. OktaOauthFlow.java
  3. okta.md

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 14, 2022
@annalvova05 annalvova05 temporarily deployed to more-secrets July 14, 2022 14:27 Inactive
@annalvova05 annalvova05 temporarily deployed to more-secrets July 14, 2022 22:37 Inactive
# Conflicts: #	airbyte-integrations/connectors/source-okta/Dockerfile #	airbyte-integrations/connectors/source-okta/acceptance-test-config.yml #	airbyte-integrations/connectors/source-okta/source_okta/schemas/logs.json #	airbyte-integrations/connectors/source-okta/source_okta/source.py #	docs/integrations/sources/okta.md
@annalvova05 annalvova05 temporarily deployed to more-secrets July 14, 2022 22:49 Inactive
@annalvova05 annalvova05 temporarily deployed to more-secrets July 14, 2022 23:08 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Jul 14, 2022

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2673660578
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2673660578
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 77 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/tests/test_incremental.py 121 25 79% source_acceptance_test/utils/common.py 80 17 79% source_acceptance_test/tests/test_core.py 294 106 64% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% ------------------------------------------------------------------------ TOTAL 960 246 74% Name Stmts Miss Cover --------------------------------------------- source_okta/__init__.py 2 0 100% source_okta/source.py 154 80 48% --------------------------------------------- TOTAL 156 80 49% 

Build Passed

Test summary info:

All Passed 
@annalvova05 annalvova05 temporarily deployed to more-secrets July 14, 2022 23:15 Inactive
@annalvova05 annalvova05 self-assigned this Jul 15, 2022
@annalvova05 annalvova05 linked an issue Jul 15, 2022 that may be closed by this pull request
@annalvova05 annalvova05 marked this pull request as ready for review July 15, 2022 09:06
@annalvova05 annalvova05 requested review from davydov-d and drrest July 15, 2022 09:08
@annalvova05 annalvova05 requested a review from pedroslopez July 15, 2022 13:23
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good work on keeping compatibility with the old config 👍🏻

"type": ["string", "null"]
},
"authenticationStep": {
"type": ["integer", "null"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing these nulls? have we confirmed that these fields are really always set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation sets that these fields are not nullable.

# Conflicts: #	airbyte-integrations/connectors/source-okta/source_okta/source.py #	docs/integrations/sources/okta.md
@annalvova05
Copy link
Contributor Author

annalvova05 commented Jul 19, 2022

/test connector=connectors/source-okta

🕑 connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2699094124
✅ connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/2699094124
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 77 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/tests/test_incremental.py 121 25 79% source_acceptance_test/utils/common.py 80 17 79% source_acceptance_test/tests/test_core.py 298 106 64% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% ------------------------------------------------------------------------ TOTAL 964 246 74% Name Stmts Miss Cover --------------------------------------------- source_okta/__init__.py 2 0 100% source_okta/source.py 174 90 48% --------------------------------------------- TOTAL 176 90 49% 

Build Passed

Test summary info:

All Passed 
@annalvova05 annalvova05 temporarily deployed to more-secrets July 19, 2022 16:23 Inactive
@annalvova05
Copy link
Contributor Author

annalvova05 commented Jul 19, 2022

/publish connector=connectors/source-okta

🕑 Publishing the following connectors:
connectors/source-okta
https://github.com/airbytehq/airbyte/actions/runs/2699148868


Connector Did it publish? Were definitions generated?
connectors/source-okta

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@annalvova05 annalvova05 merged commit 352dd51 into master Jul 19, 2022
@annalvova05 annalvova05 deleted the alvova/7516-okta-oauth branch July 19, 2022 17:02
@annalvova05 annalvova05 temporarily deployed to more-secrets July 19, 2022 17:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/okta

6 participants