Fix import order of archived data #14351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alafanechere approved these changes Jul 1, 2022
Contributor
alafanechere left a comment
alafanechere left a comment There was a problem hiding this comment.
I confirm that I can now run an import 🙏 thank you!
davinchia reviewed Jul 6, 2022
...onfig-persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java Show resolved Hide resolved
davinchia reviewed Jul 6, 2022
| } | ||
| | ||
| @Test | ||
| void testRoundTripConfig() throws Exception { |
Contributor
There was a problem hiding this comment.
@malikdiarra can confirm this is hanging.
I've tracked this down to https://github.com/airbytehq/airbyte/blob/master/airbyte-config/config-persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java#L1399. I'm not 100% sure why this is hanging here yet.
One thing I was curious about is how come the existing archive tests did not catch this. Is it missing more data? Should we add to that instead?
github-actions bot added area/platform davinchia reviewed Jul 6, 2022
airbyte-server/src/test/java/io/airbyte/server/handlers/ArchiveHandlerTest.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.