Edited UI strings for three GA connectors #13729
Conversation
…ors and Snowflake destination connector
Codecov Report
@@ Coverage Diff @@ ## master #13729 +/- ## ========================================= Coverage ? 79.48% ========================================= Files ? 14 Lines ? 892 Branches ? 0 ========================================= Hits ? 709 Misses ? 183 Partials ? 0 Continue to review full report at Codecov.
|
| @airbytehq/api-connectors-dx |
| /publish connector=connectors/source-salesforce
|
| /publish connector=connectors/destination-snowflake
|
| /publish connector=connectors/source-google-sheets
|
| ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] | ||
| | ||
| LABEL io.airbyte.version=1.0.9 | ||
| LABEL io.airbyte.version=1.1.0 |
There was a problem hiding this comment.
Note: It's ok to say 1.0.10 - unsure if bumping the minor was intended
cc @sherifnada
There was a problem hiding this comment.
+1. this doesn't have to be a minor release
There was a problem hiding this comment.
Oh, my bad. How do I fix this? Pushing a commit gives me the following error:
error: failed to push some refs to 'github.com:airbytehq/airbyte.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
There was a problem hiding this comment.
The obvious answer seems to be git pull then git push but want to make sure that's correct
There was a problem hiding this comment.
Okay, I changed the version in the dockerfile. How do I update the source_specs and source_definitions files?
Update: I see the merge conflicts but not sure if I should resolve them manually or if our automation workflow takes care of them
There was a problem hiding this comment.
I think I fixed it. Can someone verify and tell me what to do next?
…irbyte into edit_GA_connector_UI_strings
| /publish connector=connectors/destination-snowflake
|
| /publish connector=connectors/source-google-sheets
|
github-actions bot added the area/documentation 
| /publish connector=connectors/destination-snowlake,connectors/source-salesforce
if you have connectors that successfully published but failed definition generation, follow step 4 here |
| /publish connector=connectors/destination-snowlake,connectors/source-salesforce
if you have connectors that successfully published but failed definition generation, follow step 4 here |
| /publish connector=connectors/destination-snowflake
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…bytehq/airbyte into edit_GA_connector_UI_strings
…bytehq/airbyte into edit_GA_connector_UI_strings
| /publish connector=connectors/source-google-sheets
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…bytehq/airbyte into edit_GA_connector_UI_strings
| /publish connector=connectors/source-google-sheets
if you have connectors that successfully published but failed definition generation, follow step 4 here |
alafanechere left a comment
alafanechere left a comment There was a problem hiding this comment.
After fixing a quote issue in the google-sheet connector I was able to successfully publish a new version for the three connectors:
- source-google-sheets
- source-salesforce
- destination-snowflake
I'll merge now.
Edited UI strings for the Google Sheets and Salesforce source connectors and Snowflake destination connector.
My first time editing strings in the code -- let me know if I did it right!