Skip to content

Conversation

@wissevrowl
Copy link
Contributor

What

The MyHours API Schema has changed, breaking the current version.

How

The schema has been updated.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@github-actions github-actions bot added the area/connectors Connector related issues label May 18, 2022
@marcosmarxm
Copy link
Contributor

@wissevrowl let us know when this is ready to review

@alafanechere alafanechere changed the title Update Myhours API schema source Myhours: Udate API schema Jun 3, 2022
@alafanechere
Copy link
Contributor

alafanechere commented Jun 3, 2022

/test connector=connectors/source-my-hours

🕑 connectors/source-my-hours https://github.com/airbytehq/airbyte/actions/runs/2433602373
✅ connectors/source-my-hours https://github.com/airbytehq/airbyte/actions/runs/2433602373
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 77 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/tests/test_incremental.py 121 25 79% source_acceptance_test/utils/common.py 80 17 79% source_acceptance_test/tests/test_core.py 294 106 64% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% ------------------------------------------------------------------------ TOTAL 960 246 74% Name Stmts Miss Cover -------------------------------------------------- source_my_hours/stream.py 14 0 100% source_my_hours/constants.py 2 0 100% source_my_hours/__init__.py 2 0 100% source_my_hours/auth.py 31 2 94% source_my_hours/source.py 67 10 85% -------------------------------------------------- TOTAL 116 12 90% 

Build Passed

Test summary info:

=========================== short test summary info ============================ SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config ======================== 21 passed, 1 skipped in 31.93s ======================== 
@alafanechere
Copy link
Contributor

@wissevrowl I'm wondering if this should be converted as ready for review?

@wissevrowl
Copy link
Contributor Author

wissevrowl commented Jun 3, 2022

Hi @alafanechere, I'm sorry for not continuing on this PR, work got in the way. This fix is in our Airbyte deployment and has fixed the issues. The only things remaining is updating the Changelog etc.

@alafanechere alafanechere marked this pull request as ready for review June 3, 2022 12:23
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 8, 2022
@alafanechere
Copy link
Contributor

alafanechere commented Jun 8, 2022

/publish connector=connectors/source-my-hours

🕑 connectors/source-my-hours https://github.com/airbytehq/airbyte/actions/runs/2460803719
❌ Failed to publish connectors/source-my-hours
❌ Couldn't auto-bump version for connectors/source-my-hours

@alafanechere
Copy link
Contributor

alafanechere commented Jun 9, 2022

/publish connector=connectors/source-my-hours

🕑 connectors/source-my-hours https://github.com/airbytehq/airbyte/actions/runs/2467889931
🚀 Successfully published connectors/source-my-hours
🚀 Auto-bumped version for connectors/source-my-hours
✅ connectors/source-my-hours https://github.com/airbytehq/airbyte/actions/runs/2467889931

Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wissevrowl I made the additional required changes. Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants