added option for giving polling time when consuming records using kafka consumer #12903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
marcosmarxm approved these changes May 17, 2022
Contributor
marcosmarxm left a comment
marcosmarxm left a comment There was a problem hiding this comment.
thanks @tirth7777777 looks you need to sign the CLA, can you check it?
Contributor
| /test connector=connectors/source-kafka
|
tirth7777777 force-pushed the kafka_connector branch from 3dbaa59 to 6969a88 Compare Contributor Author
| @marcosmarxm I have signed the CLA. Can you merge the pullrequest |
Contributor
| /publish connector=connectors/source-kafka auto-bump-version=false
|
github-actions bot added area/api 
marcosmarxm force-pushed the kafka_connector branch from 153eed5 to fe78018 Compare github-actions bot added area/documentation github-actions bot removed CDK jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
…ords using consumer (airbytehq#12903) * added option for giving polling time using spec * add doc and seed file Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What
Added option for adding polling time when records are being consumed from Kafka consumer. Kafka consumer polling time is fixed in source-kafka
How
added polling_time in spec and added polling time as a variable in KafkaSource file
🚨 User Impact 🚨
User would be able to give polling time as input which is helpful in case when 100 ms is not enough time to collect records from kafka