- Notifications
You must be signed in to change notification settings - Fork 4.9k
#10938 fix docs and spec #11803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10938 fix docs and spec #11803
Conversation
| /test connector=connectors/source-google-analytics-v4
|
Codecov Report
@@ Coverage Diff @@ ## master #11803 +/- ## ========================================= Coverage ? 91.78% ========================================= Files ? 2 Lines ? 280 Branches ? 0 ========================================= Hits ? 257 Misses ? 23 Partials ? 0 Continue to review full report at Codecov.
|
grubberr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update source_definitions.yaml
airbyte-integrations/connectors/source-google-analytics-v4/source_google_analytics_v4/source.py Show resolved Hide resolved
after publishing a connector, the seed definitions yaml is version bumped & gradle processResources gets run automatically in CI |
| This update can be released without Airbyte review |
| /publish connector=connectors/source-google-analytics-v4
|
Source GA to Beta: fix specs and doc
Optional, set fields' order explicitlyconfig["credentials"]as required in the code (actually it is not required in spec, but will always be present due tooneOf)┆Issue is synchronized with this Monday item by Unito