Skip to content

Conversation

@davydov-d
Copy link
Contributor

@davydov-d davydov-d commented Apr 7, 2022

Source GA to Beta: fix specs and doc

  • fix doc in accordance with new template
  • fix input config: mark optional fields Optional, set fields' order explicitly
  • treat config["credentials"] as required in the code (actually it is not required in spec, but will always be present due to oneOf)
  • remove an odd fixture in unit tests

┆Issue is synchronized with this Monday item by Unito

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 7, 2022
@davydov-d
Copy link
Contributor Author

davydov-d commented Apr 7, 2022

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2109690877
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2109690877
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/config.py 74 6 92% source_acceptance_test/utils/json_schema_helper.py 105 13 88% source_acceptance_test/utils/common.py 70 17 76% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/tests/test_core.py 285 106 63% source_acceptance_test/base.py 10 4 60% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/tests/test_incremental.py 69 38 45% ------------------------------------------------------------------------ TOTAL 886 259 71% Name Stmts Miss Cover ------------------------------------------------------------ source_google_analytics_v4/__init__.py 2 0 100% source_google_analytics_v4/source.py 278 23 92% ------------------------------------------------------------ TOTAL 280 23 92% 
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@6092bee). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #11803 +/- ## ========================================= Coverage ? 91.78% ========================================= Files ? 2 Lines ? 280 Branches ? 0 ========================================= Hits ? 257 Misses ? 23 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6092bee...2b859a7. Read the comment docs.

Copy link
Contributor

@grubberr grubberr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update source_definitions.yaml

@davydov-d davydov-d requested a review from grubberr April 12, 2022 07:59
@davydov-d
Copy link
Contributor Author

Please update source_definitions.yaml

after publishing a connector, the seed definitions yaml is version bumped & gradle processResources gets run automatically in CI

@midavadim
Copy link
Contributor

This update can be released without Airbyte review

@davydov-d
Copy link
Contributor Author

davydov-d commented Apr 13, 2022

/publish connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2160453444
🚀 Successfully published connectors/source-google-analytics-v4
🚀 Auto-bumped version for connectors/source-google-analytics-v4
✅ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/2160453444

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 13, 2022 10:18 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 13, 2022 10:18 Inactive
@davydov-d davydov-d merged commit a673a47 into master Apr 13, 2022
@davydov-d davydov-d deleted the ddavydov/10938-ga-to-beta-fix-docs branch April 13, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

6 participants