Skip to content

Conversation

@lazebnyi
Copy link
Contributor

@lazebnyi lazebnyi commented Feb 15, 2022

What

#110 - Fix backoff trigger with ConnectionError

How

Added 104 status code to backoff errors code list.

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
@lazebnyi lazebnyi requested a review from antixar February 15, 2022 13:50
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 15, 2022
@lazebnyi lazebnyi requested a review from annalvova05 February 15, 2022 13:50
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 13:58 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 13:58 Inactive
@lazebnyi lazebnyi force-pushed the lazebnyi/110-facebook-markeketing-fix-backoff-error-codes branch from f22e125 to b4b9cff Compare February 15, 2022 14:01
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 14:03 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 14:03 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Feb 15, 2022

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1847397663
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1847397663
Python tests coverage:

Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 74 6 92% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 275 106 61% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 70 17 76% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/utils/json_schema_helper.py 105 13 88% ------------------------------------------------------------------------ TOTAL 876 259 70% Name Stmts Miss Cover ------------------------------------------------------------ source_facebook_marketing/__init__.py 2 0 100% source_facebook_marketing/api.py 75 17 77% source_facebook_marketing/async_job.py 92 58 37% source_facebook_marketing/common.py 39 12 69% source_facebook_marketing/source.py 114 66 42% source_facebook_marketing/streams.py 287 108 62% ------------------------------------------------------------ TOTAL 609 261 57% Name Stmts Miss Cover ------------------------------------------------------------ source_facebook_marketing/__init__.py 2 0 100% source_facebook_marketing/api.py 75 18 76% source_facebook_marketing/async_job.py 92 1 99% source_facebook_marketing/common.py 39 1 97% source_facebook_marketing/source.py 114 73 36% source_facebook_marketing/streams.py 287 78 73% ------------------------------------------------------------ TOTAL 609 171 72% 
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 14:07 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 15, 2022 14:07 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 15, 2022 14:08 Inactive
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lazebnyi , please publish your changes

@lazebnyi lazebnyi marked this pull request as ready for review February 18, 2022 13:38
@lazebnyi lazebnyi temporarily deployed to more-secrets February 18, 2022 13:44 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 18, 2022 13:44 Inactive
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@303d103). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 198ca57 differs from pull request most recent head 6977001. Consider uploading reports for the commit 6977001 to get more accurate results

Impacted file tree graph

@@ Coverage Diff @@ ## master #10348 +/- ## ========================================= Coverage ? 87.37% ========================================= Files ? 11 Lines ? 808 Branches ? 0 ========================================= Hits ? 706 Misses ? 102 Partials ? 0 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303d103...6977001. Read the comment docs.

@lazebnyi
Copy link
Contributor Author

lazebnyi commented Feb 18, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1864766882
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1864766882

@lazebnyi lazebnyi temporarily deployed to more-secrets February 18, 2022 13:59 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 18, 2022 13:59 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 14:02 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Feb 22, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1881184776
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1881184776

@lazebnyi lazebnyi removed the request for review from annalvova05 February 22, 2022 11:10
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 11:14 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 11:14 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 11:15 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 13:48 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 13:48 Inactive
@lazebnyi
Copy link
Contributor Author

lazebnyi commented Feb 22, 2022

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1881926728
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1881926728

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 13:52 Inactive
@lazebnyi lazebnyi merged commit ca1cf9b into master Feb 22, 2022
@lazebnyi lazebnyi deleted the lazebnyi/110-facebook-markeketing-fix-backoff-error-codes branch February 22, 2022 15:26
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:26 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets February 22, 2022 15:26 Inactive
@lazebnyi lazebnyi restored the lazebnyi/110-facebook-markeketing-fix-backoff-error-codes branch March 9, 2022 13:26
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 13:28 Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets March 9, 2022 13:28 Inactive
@lazebnyi lazebnyi deleted the lazebnyi/110-facebook-markeketing-fix-backoff-error-codes branch April 3, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation

4 participants