🎉 Source Stripe:: improve 404 handling for CheckoutSessionsLineItems stream

[grubberr]

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix this PR https://github.com/airbytehq/oncall/issues/127

There was inconsistency between this 2 HTTP requests:

1. https://api.stripe.com/v1/checkout/sessions 2. https://api.stripe.com/v1/checkout/sessions/{checkout_session_id}/line_items 

First HTTP request returned session_id=cs_live_HaU2qbxGozr98NLN6PQVtAEP2kJciKAIq337MY763uWCi89kXT08l9lM
and 2-nd request returned 404 for this session_id. This can happen if during 1-st HTTP request object existed on server but brefore 2-nd HTTP request object was already removed by somebody else.

How

Current solution just skip such 404 sub-requests and log them.

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• Credentials added to Github CI. Instructions.
• /test connector=connectors/<name> command is passing.
• New Connector version released on Dockerhub by running the /publish command described here
• After the new connector version is published, connector version bumped in the seed directory as described here
• Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@84d1456). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #10165 +/- ## ========================================= Coverage ? 70.22% ========================================= Files ? 3 Lines ? 225 Branches ? 0 ========================================= Hits ? 158 Misses ? 67 Partials ? 0 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d1456...0c317e2. Read the comment docs.

[grubberr]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1809495197
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1809495197
🐛 https://gradle.com/s/jetn5glaqib6s
Python short test summary info:

=========================== short test summary info ============================ FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs2] =================== 1 failed, 34 passed in 489.13s (0:08:09) =================== 

[grubberr]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1811244334
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1811244334
🐛 https://gradle.com/s/47k2kxkun2d5q
Python short test summary info:

=========================== short test summary info ============================ FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs2] =================== 1 failed, 34 passed in 500.28s (0:08:20) =================== 

[bazarnov]

Can we handle the response errors for all streams? It looks like the error could be floating.

[grubberr]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1814335690
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1814335690
Python tests coverage:

Name Stmts Miss Cover ----------------------------------------------- source_stripe/__init__.py 2 0 100% source_stripe/source.py 22 11 50% source_stripe/streams.py 202 56 72% ----------------------------------------------- TOTAL 226 67 70% Name Stmts Miss Cover ------------------------------------------------------------------------ source_acceptance_test/__init__.py 2 0 100% source_acceptance_test/base.py 10 4 60% source_acceptance_test/config.py 74 6 92% source_acceptance_test/tests/__init__.py 4 0 100% source_acceptance_test/tests/test_core.py 275 106 61% source_acceptance_test/tests/test_full_refresh.py 52 2 96% source_acceptance_test/tests/test_incremental.py 69 38 45% source_acceptance_test/utils/__init__.py 6 0 100% source_acceptance_test/utils/asserts.py 37 2 95% source_acceptance_test/utils/common.py 70 17 76% source_acceptance_test/utils/compare.py 62 23 63% source_acceptance_test/utils/connector_runner.py 110 48 56% source_acceptance_test/utils/json_schema_helper.py 105 13 88% ------------------------------------------------------------------------ TOTAL 876 259 70% 

[antixar]

LGTM
Please deploy your changes

[grubberr]

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1820037239
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1820037239