Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Fix potential stream hangs by ensuring completion callback #52

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Fix potential stream hangs by ensuring completion callback #52

merged 2 commits into from
Jan 30, 2025

Conversation

@emredmrcan
Copy link
Contributor

@emredmrcan emredmrcan commented Dec 5, 2024 •
edited by ai-for-java
Loading

Issue

Closes langchain4j/langchain4j#2048

Change

Ensure that the completion callback is called even if the [DONE] event is not received.

General checklist

  • There are no breaking changes
  • I have added unit and/or integration tests for my change
  • The tests cover both positive and negative cases
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
ai-for-java
ai-for-java approved these changes Jan 30, 2025
View reviewed changes
Copy link
Owner

@ai-for-java ai-for-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emredmrcan thank you!
@ai-for-java ai-for-java merged commit 8263f57 into ai-for-java:main Jan 30, 2025
@dliubarskyi dliubarskyi mentioned this pull request Jan 30, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@emredmrcan @ai-for-java