This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Add a method to customize the User Agent #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
YannRobert reviewed Mar 11, 2024
| private DefaultOpenAiClient(Builder serviceBuilder) { | ||
| this.baseUrl = serviceBuilder.baseUrl; | ||
| this.apiVersion = serviceBuilder.apiVersion; | ||
| this.userAgent = serviceBuilder.userAgent; |
There was a problem hiding this comment.
new member field userAgent is not used
so it's probably not needed
There was a problem hiding this comment.
Indeed I messed up! But that's already merged, so I'll do another PR
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allow the customization of the "User-Agent" sent as a header by okhttp3.
My goal is to use it in LangChain4J OpenAI at https://github.com/langchain4j/langchain4j/tree/main/langchain4j-open-ai to have something similar to what we have in LangChain4J Azure OpenAI (see https://github.com/langchain4j/langchain4j/blob/200522f558509a67e940ae4c82284b85caaebef8/langchain4j-azure-open-ai/src/main/java/dev/langchain4j/model/azure/InternalAzureOpenAiHelper.java#L77 ).
This is important as this allows Azure OpenAI (and probably also OpenAI) to see which tool or library people are using, which is important to get support from them.