DirectBuffer - Support ArraySegment for underlying array #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What: Support ArraySegment for underlying array
Why: It's useful to be able to read an SBE message from a view (i.e. ArraySegment) on a big array of bytes, without copies. Currently, we'd have to slice the byte array, which results in a copy.
How: similar to the
byte[]case, pin the ArraySegment's underlying buffer so the GC doesn't move it, then offset the created pointer by the ArraySegment offset so that we point to the right memory.Testing: run unit tests locally with
./runtestsNote: The C# wrappers should really be re-written using structs and Spans, which would enable fast and memory efficient code while still being safe, which the current code is not. Then again, that's a non-trivial undertaking, so this will suffice for now :)